Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reader: Fix a few places where we use tracks directly #3523

Merged
merged 3 commits into from
Feb 24, 2016
Merged

Reader: Fix a few places where we use tracks directly #3523

merged 3 commits into from
Feb 24, 2016

Conversation

blowery
Copy link
Contributor

@blowery blowery commented Feb 24, 2016

Use reader/stats/recordTrack instead to inject the subscription count

@blowery blowery added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] Reader The reader site on Calypso. labels Feb 24, 2016
@blowery blowery added this to the Reader: UI Nits milestone Feb 24, 2016
@blowery blowery self-assigned this Feb 24, 2016
@bluefuton
Copy link
Contributor

Related to #3517.

@bluefuton
Copy link
Contributor

Events to check:

  • calypso_reader_infinite_scroll_performed
  • calypso_reader_blog_preview
  • calypso_reader_tag_loaded
  • calypso_reader_list_loaded
  • calypso_reader_discover_viewed
  • calypso_reader_unblock_site
  • calypso_reader_site_followed
  • calypso_reader_site_unfollowed

@bluefuton
Copy link
Contributor

Looks good.

Noticed while testing that calypso_reader_block_site does not fire an event - worth adding one while we're at it?

@blowery
Copy link
Contributor Author

blowery commented Feb 24, 2016

Noticed while testing that calypso_reader_block_site does not fire an event - worth adding one while we're at it?

Done

@bluefuton
Copy link
Contributor

Looks good! :shipit:

blowery added a commit that referenced this pull request Feb 24, 2016
@blowery
Merge pull request #3523 from Automattic/fix/reader-stats-should-use-…
474d3da 
…reader-stats

Reader: Fix a few places where we use tracks directly
@blowery blowery merged commit 474d3da into master Feb 24, 2016
@blowery blowery deleted the fix/reader-stats-should-use-reader-stats branch February 24, 2016 02:51
@scruffian scruffian removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 24, 2016
@awaisab172 awaisab172 mentioned this pull request Jun 24, 2023
Open
@awaisab172 awaisab172 mentioned this pull request Feb 11, 2024
Open
@awaisab172 awaisab172 mentioned this pull request Mar 23, 2024
Open
@awaisab172 awaisab172 mentioned this pull request May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@blowery blowery

Labels
[Feature] Reader The reader site on Calypso.
Projects
None yet
Milestone
Reader: UI Nits
Development

Successfully merging this pull request may close these issues.
3 participants
@blowery @bluefuton @scruffian