-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/gutenboarding hide next button in intent gathering step #38705
Merged
andrewserong
merged 5 commits into
master
from
update/gutenboarding-hide-next-button-in-intent-gathering-step
Jan 15, 2020
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
36744ab
Hide Next button on IntentGathering step in Gutenboarding
andrewserong 4a2418a
Remove constant and use isNextHidden prop in Header component instead
andrewserong fc84ff1
Reemove isNextHidden boolean and switch setSelectedDesign to use word…
andrewserong a66eb1e
Group selectedDesign with siteVertical useSelect in the design select…
andrewserong 1e3bc27
Remove siteVertical from Gutenboard to fix issue missed during rebase
andrewserong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,6 @@ import { | |
} from '@wordpress/block-editor'; | ||
import { Popover, DropZoneProvider } from '@wordpress/components'; | ||
import { createBlock, registerBlockType } from '@wordpress/blocks'; | ||
import { useSelect } from '@wordpress/data'; | ||
import '@wordpress/format-library'; | ||
import React, { useRef } from 'react'; | ||
// Uncomment and remove the redundant sass import from `./style.css` when a release after @wordpress/[email protected] is published. | ||
|
@@ -24,30 +23,22 @@ import { useRouteMatch } from 'react-router-dom'; | |
*/ | ||
import Header from './components/header'; | ||
import { name, settings } from './onboarding-block'; | ||
import { STORE_KEY } from './stores/onboard'; | ||
import { routes, Step } from './steps'; | ||
import './style.scss'; | ||
|
||
registerBlockType( name, settings ); | ||
|
||
export function Gutenboard() { | ||
const { siteVertical } = useSelect( select => select( STORE_KEY ).getState() ); | ||
|
||
// @TODO: This is currently needed in addition to the routing (inside the Onboarding Block) | ||
// for the 'Back' and 'Next' buttons in the header. If we remove those (and move navigation | ||
// entirely into the block), we'll be able to remove this code. | ||
const r = useRouteMatch( routes ); | ||
let next: undefined | string; | ||
let prev: undefined | string; | ||
switch ( r?.url ) { | ||
case Step.IntentGathering: | ||
if ( siteVertical ) { | ||
next = Step.DesignSelection; | ||
} | ||
break; | ||
|
||
case Step.DesignSelection: | ||
prev = Step.IntentGathering; | ||
next = Step.CreateSite; | ||
break; | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,6 +20,16 @@ const domain: Reducer< | |
return state; | ||
}; | ||
|
||
const selectedDesign: Reducer< | ||
import('@automattic/data-stores').VerticalsTemplates.Template | undefined, | ||
ReturnType< typeof Actions[ 'setSelectedDesign' ] > | ||
> = ( state = undefined, action ) => { | ||
if ( action.type === ActionType.SET_SELECTED_DESIGN ) { | ||
return action.selectedDesign; | ||
} | ||
return state; | ||
}; | ||
Comment on lines
+23
to
+31
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 Looks good. Did you have any hangups working on this? |
||
|
||
const siteTitle: Reducer< string, ReturnType< typeof Actions[ 'setSiteTitle' ] > > = ( | ||
state = '', | ||
action | ||
|
@@ -57,7 +67,7 @@ const pageLayouts: Reducer< | |
return state; | ||
}; | ||
|
||
const reducer = combineReducers( { domain, siteTitle, siteVertical, pageLayouts } ); | ||
const reducer = combineReducers( { domain, selectedDesign, siteTitle, siteVertical, pageLayouts } ); | ||
|
||
export type State = ReturnType< typeof reducer >; | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍