Gutenboarding: remove save text node override in the block editor #42508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not sure of the mechanism behind the error, but the page fails when React attempt to unmount components. It's looking for a precise node tree it appears.
ramonjd
added
[Type] Bug
ramonjd
added
the
[Status] Needs Review
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
p-jackson
approved these changes
May 21, 2020
There was a problem hiding this comment.
LGTM. Saving, publishing and launch flows working as expected.
We have other things we should fix up about the editor overrides for unpublished posts (e.g. we're changing the publish confirmation button to a tertiary style) but this fixes the crash.
And leaving the button as "Update" for published posts isn't too bad. I know it was a very conscious decision to change it to save, but at least "Update" isn't completely wrong.
andrewserong
approved these changes
May 21, 2020
|
Thank you, @p-jackson and @andrewserong once again for your continued service to the cause
|
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Create a site with Gutenboarding at
/newNow try to create and publish a new post or page.
You can't, can you?
Do you see this?
It's because we're manipulating the buttons in the editor's header, specifically the text node in the publish button.
Let's not replace the text node as React does not like it at all. I'm not sure of the mechanism behind the error, but the page fails when React attempt to unmount components. It's looking for a precise node tree it appears.
props to @ianstewart for finding this bug and giving us something do
Testing instructions
Code to patch in D43745-code