Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purchases: Add analytics to the contact support links #479

Merged
merged 3 commits into from
Nov 24, 2015

Conversation

scruffian
Copy link
Member

Adds a calypso_purchases_click_contact_support event to the contact support links on the cancel purchase page.

Fixes #271 (part of it)

Testing

  1. git checkout fix/12207-analytics
  2. Open http://calypso.dev:3000/purchases
  3. Add calypso:analytics to the debugger so you see analytics calls in your console
  4. Open a purchase and go to the cancel page
  5. Click the "contact support" links (there are two)
  6. Assert that you see this event: calypso_purchases_click_contact_support with the product_slug property.
  • Code review
  • QA review

@scruffian scruffian added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. labels Nov 23, 2015
@scruffian scruffian self-assigned this Nov 23, 2015
@scruffian scruffian added this to the Purchases: v1 milestone Nov 23, 2015
@scruffian scruffian mentioned this pull request Nov 23, 2015
13 tasks
@scruffian scruffian force-pushed the add/purchases-contact-support-analytics branch from 7ea9c1d to 9e8b36f Compare November 23, 2015 11:07
@fabianapsimoes
Copy link
Contributor

QA 👍

@scruffian scruffian force-pushed the add/purchases-contact-support-analytics branch from 4caf8ed to 2458cb7 Compare November 23, 2015 17:21
@drewblaisdell drewblaisdell force-pushed the add/purchases-contact-support-analytics branch from 2458cb7 to dd9ec90 Compare November 23, 2015 23:07
},

trackClickContactSupport() {
if ( ! this.props.purchase ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this line? purchase is a required prop, and this is only mounted when the purchase is loaded in CancelPurchase.

@drewblaisdell
Copy link
Contributor

I updated your first commit to fix a small typo, and had one note about removing an unnecessary condition from trackClickContactSupport. If you're cool with that change, this LGTM.

@drewblaisdell drewblaisdell added [Status] Ready to Merge [Feature] Tracks Metrics & Monitoring Capturing analytics about user behavior on WordPress.com. and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 23, 2015
@scruffian scruffian force-pushed the add/purchases-contact-support-analytics branch from dd9ec90 to f47fce3 Compare November 24, 2015 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Feature] Tracks Metrics & Monitoring Capturing analytics about user behavior on WordPress.com.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Purchases: Analytics
3 participants