-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Purchases: Add analytics to the contact support links #479
Conversation
7ea9c1d
to
9e8b36f
Compare
QA 👍 |
4caf8ed
to
2458cb7
Compare
2458cb7
to
dd9ec90
Compare
}, | ||
|
||
trackClickContactSupport() { | ||
if ( ! this.props.purchase ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this line? purchase
is a required prop, and this is only mounted when the purchase is loaded in CancelPurchase
.
I updated your first commit to fix a small typo, and had one note about removing an unnecessary condition from |
dd9ec90
to
f47fce3
Compare
8ca58a5
to
cd4e1d7
Compare
…-analytics Purchases: Add analytics to the contact support links
Adds a
calypso_purchases_click_contact_support
event to the contact support links on the cancel purchase page.Fixes #271 (part of it)
Testing
git checkout fix/12207-analytics
calypso:analytics
to the debugger so you see analytics calls in your consolecalypso_purchases_click_contact_support
with theproduct_slug
property.