-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Top bar: Spacing tweaks to match front end #51720
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ont end top bar styles
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
…ylesheet area as their individual buttons
mreishus
approved these changes
Apr 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
You'll notice that in some cases the top bar is still not a 1:1 replica between Calypso and the front end; I didn't want to go down the rabbit hole of pixel-perfection, this should iron out the most obvious kinks. If we want 100% visual parity I can continue picking away at pixels. :)
Visual differences by screen size
The front end toolbar has not changed in this PR; I only include the images for comparison
Before
After
Front end
Before
![Screen Shot 2021-04-07 at 11 11 46 AM](https://user-images.githubusercontent.com/2124984/113900525-e86b4000-979b-11eb-8fac-bed036635178.png)
After
![Screen Shot 2021-04-07 at 11 11 57 AM](https://user-images.githubusercontent.com/2124984/113900556-f0c37b00-979b-11eb-9d8d-45117c24f699.png)
Front end
![Screen Shot 2021-04-07 at 11 12 05 AM](https://user-images.githubusercontent.com/2124984/113900578-f6b95c00-979b-11eb-8ed4-22fbdf55d5ba.png)
Before
After
Front end
Testing instructions
Related to #49154