Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Hide Launch button from top bar on small screens #53097

Closed
wants to merge 1 commit into from
Closed

Editor: Hide Launch button from top bar on small screens #53097

wants to merge 1 commit into from

Conversation

razvanpapadopol
Copy link

@razvanpapadopol razvanpapadopol commented May 22, 2021 •
edited
Loading

Changes proposed in this Pull Request

Testing instructions

  • Apply patch
  • Sandbox an unlaunched site
  • Open page/post editor on a viewport less than 480px wide
  • There should be no "Launch" button

Screenshots (Iphone SE)

Before

Screenshot 2021-05-22 at 07 59 25

After

Screenshot 2021-05-22 at 07 59 41

Related to #50758

@razvanpapadopol razvanpapadopol added [Feature] Post/Page Editor The editor for editing posts and pages. Mobile Web Editing Toolkit For issues and PRs that affect the Editing Toolkit plugin labels May 22, 2021
@razvanpapadopol razvanpapadopol self-assigned this May 22, 2021
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 22, 2021
@github-actions
Copy link

Test live: https://calypso.live/?branch=fix/etk--mobile-header-alignment

@razvanpapadopol
Copy link
Author

#53109 makes this redundant.

@razvanpapadopol razvanpapadopol deleted the fix/etk--mobile-header-alignment branch May 24, 2021 08:12
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simison simison Awaiting requested review from simison

@StefanNieuwenhuis StefanNieuwenhuis Awaiting requested review from StefanNieuwenhuis

Assignees

@razvanpapadopol razvanpapadopol

Labels
Editing Toolkit For issues and PRs that affect the Editing Toolkit plugin [Feature] Post/Page Editor The editor for editing posts and pages. Mobile Web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@razvanpapadopol @matticbot @creativecoder