FormPhoneInput: Remove LinkedStateMixin #5554
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is obsolete, since FormPhoneInput doesn't use the
this.linkState()
method provided by the mixin, but instead handles the relavant logic itself in itscountryValueLink
andphoneValueLink
objects -- very much like the textbook example, https://facebook.github.io/react/docs/two-way-binding-helpers.html#reactlink-without-linkedstatemixinAlso, LinkedStateMixin is deprecated as of React 15, so it's a good thing to remove it.
Additionally, this PR changes the initial value of the
FormFields
example'FormPhoneInput
to a valid format (cf p6jOYE-sc-p2).Code QA:
this.linkState()
inFormPhoneInput
)To test: