Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Announcement Modal: add tracks event for dismiss. #57693

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

cpapazoglou
Copy link
Contributor

@cpapazoglou cpapazoglou commented Nov 5, 2021

Changes proposed in this Pull Request

  • Adds a calypso_announcement_modal_dismiss track event with an announcementId parameter
  • moves the UserId param to the end of the dismissPreference

Testing instructions

  • load Calypso
  • in the console enter localStorage.setItem( 'debug', 'calypso:analytics*' )
  • reload the page
  • go to /plugins
  • dismiss the modal (if you have already dismissed it, remove it from the debug menu -> preferences)
  • make sure that the calypso_announcement_modal_dismiss event is logged and announcementId parameter matches plugins-page-revamp

SS 2021-11-05 at 12 15 23

Fixes #57692

@github-actions
Copy link

github-actions bot commented Nov 5, 2021

@cpapazoglou cpapazoglou self-assigned this Nov 5, 2021
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~24 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
plugins        +70 B  (+0.0%)      +24 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@WBerredo WBerredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpapazoglou cpapazoglou merged commit 0178a4a into trunk Nov 10, 2021
@cpapazoglou cpapazoglou deleted the add/announcement_modal_dismiss_track_event branch November 10, 2021 15:00
nelsonec87 pushed a commit that referenced this pull request Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Announcement modal: add track events
3 participants