-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invites: Improves translated string for invite header #582
Conversation
break; | ||
case 'author': | ||
text = this.translate( | ||
'{{inviterName/}} invited you to author on:', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
invited you to be an author on:
They all seem great except this is weird:
Let's go with
It doesn't match the others if we don't use 'author' as a verb, but I don't feel it's commonly used as a verb these days. |
switch ( get( this.props, 'invite.meta.role' ) ) { | ||
case 'administrator': | ||
text = this.translate( | ||
'{{inviterName/}} invited you to administer:', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
User invited you to administer:
feels a bit strange. I'd prefer User invited you to manage:
Code looks great, and works as expected. I left one minor wording fix. |
…ings Invites: Improves translated string for invite header
It appears this is already merged, but I don't think we should have switched to use the word 'manage'. The role is 'admin' so I think using some derivation of that term is important.
|
Addresses part of #138 and related to #369
To test:
update/invite-header-role-strings
branchUsers > Invite New
inwp-admin
/accept-invite/$site/$invite_key
wp-admin
cc @roccotripaldi for review and @rickybanister for wording review