Jetpack Partner Coupon: prioritise coupon redirect

[kallehauge]

Summary

The current implementation of catching a Jetpack partner coupon and redirecting users directly to checkout is having some issues. Specifically with sites that have a partner ID.

We would expect all from: jetpack-partner-coupon flows to be send over to the plans page after authorisation.
We specifically catch users on the plans page and redirect them because we expect to make special upsell offers on the plan page in the future, so we might as well make sure the flow works now - which will also allow us to do it async of Jetpack plugin releases.

An issue we currently face is that some redirect conditions take over the normal flow like; is it a partner hosted site? (the shouldRedirectJetpackStart redirect condition).
We should prioritise the coupon redirect over these conditions because the customer has specifically entered the partner coupon flow and is expected to "Go straight to checkout".

Aside: I would consider this a pretty low risk change since we require the "from" property to specifically be jetpack-partner-coupon, so I'm not too worried about actually messing with existing flows.

Changes proposed in this Pull Request

• Prioritise "Jetpack Partner Coupon" condition in the Calypso redirect conditions after a user has authorized a Jetpack connection.

Testing instructions

Verify failing flow

• Spin up a Jurassic Ninja site
  • Go to "Want more options?"
  • Select Include Jetpack Beta
  • Select add/partner-coupon-connection as the Jetpack branch
  • Go down to "Plugins" and select "Include Code Snippets"
• Copy the Filters snippet found below to a Code Snippet (this will make the WordPress site recognise test coupons and the flow will not work without it).
• Create a Site Connection with the Jetpack Licensing API or a free plan with Jetpack Start API.
  • We do this step so the site will be recognized as having special conditions due to partner provisioned plans.
• Go to /wp-admin/admin.php?jetpack-partner-coupon=JPTST_JPTA_123AB.
• Click the "Redeem " button.
• Press the "Approve" / "Authorize" button in Calypso.
• You should now be taken back to your WordPress site without seeing the checkout (this is the failure we want to fix).

Verify fixed flow
This assumes that you've just completed Verify failing flow and continues in the same flow.

• Go through all the steps of Verify failing flow right up until you get redirected back to WP Admin.
• Disconnect Jetpack.
• Go to /wp-admin/admin.php?page=jetpack#/dashboard
• You should now see the redeem component again.
• Click the "Set up & redeem " button.
• Spin up this branch.
  • Start up Calypso locally with this branch and use http://calypso.localhost:3000.
  • Use the Calypso link generated with this PR.
• Copy the URL and replace https://wordpress.com with http://calypso.localhost:3000 / the PR link.
• Go to the development URL.
• Press the "Approve" / "Authorize" button in Calypso.
• You should now be taken directly to Jetpack Checkout (whereas you got redirect to WP Admin before in the live version).

Filters snippet

add_filter( 'jetpack_partner_coupon_supported_partners', function ( $partners ) {
	$partners['JPTST'] = 'Jetpack Test';

	return $partners;
} );

add_filter( 'jetpack_partner_coupon_supported_presets', function ( $presets ) {
	$presets['JPTA'] = 'jetpack_backup_daily';

	return $presets;
} );

Related to Automattic/jetpack#21813

[github-actions]

Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-20558
Link to Jetpack Cloud live: https://calypso.live?image=registry.a8c.com/calypso/app:build-20558&env=jetpack

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~76 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
jetpack-connect       +337 B  (+0.0%)      +76 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[kallehauge]

Just a note about the failing E2E Tests (mobile) (Web app) build: it's an unrelated test that failed 🙂

[rcanepa]

LGTM.

Code changes look reasonable and work as per instructions.

Aside: I would consider this a pretty low risk change since we require the "from" property to specifically be jetpack-partner-coupon, so I'm not too worried about actually messing with existing flows.

I agree with this statement so I think we can safely ship this.

[rcanepa]

After the last commit, I gave this PR a second review, and I can confirm that everything still works as expected. I appreciate the simplification introduced in the last commit.

✅