Delete editor site launch #75037
Delete editor site launch #75037
Conversation
matticbot
added
the
[Status] Needs Review
|
This PR modifies the release build for editing-toolkit To test your changes on WordPress.com, run To deploy your changes after merging, see the documentation: PCYsg-mMA-p2 |
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Great work @noahtallen!
I've suggested removing a few more dependencies that we no longer seem to use.
Could be done in a separate PR if that works better for you.
🚀
| import { GUTENBOARDING_LAUNCH_FLOW } from '../constants'; | ||
|
|
||
| import 'a8c-fse-common-data-stores'; | ||
| import '@wordpress/editor'; |
There was a problem hiding this comment.
Is this removing the last use of @wordpress/editor? Can we remove that dependency from editing toolkit altogether?
| } | ||
| } | ||
|
|
||
| .editor-gutenberg-launch__launch-button { |
There was a problem hiding this comment.
We can also likely delete this then:
wp-calypso/packages/launch/src/focused-launch/style.scss
Lines 7 to 9 in b7a4a07
| @@ -1,20 +0,0 @@ | |||
| @import "@automattic/onboarding/styles/mixins"; | |||
| @import "@automattic/plans-grid/src/variables"; | |||
There was a problem hiding this comment.
Seems like we can remove the @automattic/plans-grid dependency from ETK now.
| @@ -1,86 +0,0 @@ | |||
| import { useSite } from '@automattic/launch'; | |||
There was a problem hiding this comment.
Seems like we can remove the @automattic/launch dependency from ETK now.
| CheckoutStepAreaWrapper, | ||
| SubmitButtonWrapper, | ||
| FormStatus, | ||
| } from '@automattic/composite-checkout'; |
There was a problem hiding this comment.
Seems like we can remove the @automattic/composite-checkout dependency from ETK now.
| import { useLocale, useLocalizeUrl } from '@automattic/i18n-utils'; | ||
| import { useSiteDomains, useDomainSuggestion, useDomainSearch, useTitle } from '@automattic/launch'; | ||
| import { Title, SubTitle, ActionButtons, BackButton } from '@automattic/onboarding'; | ||
| import { ThemeProvider } from '@emotion/react'; |
There was a problem hiding this comment.
Do we still need @emotion/react as a dependency of ETK after the removal of this? I think we don't.
| import { createInterpolateElement } from '@wordpress/element'; | ||
| import { sprintf } from '@wordpress/i18n'; | ||
| import { Icon, check } from '@wordpress/icons'; | ||
| import { useI18n } from '@wordpress/react-i18n'; |
There was a problem hiding this comment.
Seems like we no longer use @wordpress/react-i18n after this PR. Should we remove that dependency and its special handling here:
|
Good finds! I'll look into removing those in this PR. |
|
I'm going to proceed and merge this to unblock some further cleanup work. Going to open a new PR with my suggestions so we don't lose track of them. Thanks, @noahtallen! 🚀 |
github-actions
bot
removed
the
[Status] Needs Review
|
Follow-up cleanup: #75267 |
|
Thanks! |
Related to #
Proposed Changes
I couldn't find anywhere this directory was imported, so I'm deleting it (and also removing some unused deps in ETK). Related partially to #74551.
For this feature to load, its PHP would have to be enqueued by something.... and I don't think it is 😁
I accidentally discovered this today, but when looking back, I found we've discussed this previously: #53118
Testing Instructions