Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Use key-mirror in place of react/lib/keyMirror #776

Merged
merged 1 commit into from
Nov 26, 2015

Conversation

aduth
Copy link
Contributor

@aduth aduth commented Nov 25, 2015

Related: #786, #787

This pull request seeks to replace existing usage of the react/lib/keyMirror module with the standalone key-mirror package. This is a prerequisite for upgrading to React 0.14. Facebook has moved library modules to a separate package, which they warn against using.

Note: If you are consuming the code here and you are not also a Facebook project, be prepared for a bad time. APIs may appear or disappear and we may not follow semver strictly, though we will do our best to. This library is being published with our use cases in mind and is not necessarily meant to be consumed by the broader public.

https://github.com/facebook/fbjs

Testing instructions:

Ensure that no references remain for react/lib/keyMirror. Verify also that the application continues to load, especially for pages making use of key-mirror functionality.

/cc @blowery 11943-gh-calypso-pre-oss

@aduth aduth added Framework [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 25, 2015
@blowery blowery added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 25, 2015
@blowery
Copy link
Contributor

blowery commented Nov 25, 2015

👍

aduth added a commit that referenced this pull request Nov 26, 2015
Framework: Use key-mirror in place of react/lib/keyMirror
@aduth aduth merged commit 8eaf1cc into master Nov 26, 2015
@aduth aduth deleted the update/react-lib-key-mirror branch November 26, 2015 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants