Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: Add a min-height for featured images in refresh stream #8823

Closed
wants to merge 1 commit into from

Conversation

blowery
Copy link
Contributor

@blowery blowery commented Oct 18, 2016

This prevents cards from totally collapsing when the excerpt is short.

This prevents cards from totally collapsing when the excerpt is short.
@matticbot
Copy link
Contributor

@blowery blowery added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] Reader The reader site on Calypso. labels Oct 18, 2016
@blowery blowery added this to the Reader: Stream Refresh milestone Oct 18, 2016
@blowery
Copy link
Contributor Author

blowery commented Oct 18, 2016

Not the best example, because this card has no excerpt, but this would help with cases where the post has 2 images and a short excerpt.

before
following_ _reader_ _wordpress_com

after
following_ _reader_ _wordpress_com

@blowery
Copy link
Contributor Author

blowery commented Oct 18, 2016

here's 125px
following_ _reader_ _wordpress_com

@jancavan
Copy link
Contributor

@blowery I'm working on photo-only cards atm which we will use for these type of cards.

@blowery
Copy link
Contributor Author

blowery commented Oct 18, 2016

@jancavan right, the post here is a bad example. But there are posts that have short excerpts and just a couple images. Under the current rules, they won't trip the gallery card and the excerpt won't be long enough to fill out the card...

Maybe we just sit on this one till photo and gallery cards land, then circle back to see if this is required?

@fraying

@fraying
Copy link
Contributor

fraying commented Oct 18, 2016

Agreed! The example above would become a Photo card. So there should be no issue.

@jancavan
Copy link
Contributor

We'll be using photo cards for:

If the post has 1 or more images and less than 130 characters: Photo card (using featured image or first image).

@jancavan
Copy link
Contributor

Photo-only card PR: #8843

@bluefuton bluefuton added [Status] Punted and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 19, 2016
@blowery blowery closed this Oct 25, 2016
@lancewillett lancewillett deleted the update/reader/min-height-on-features branch October 26, 2016 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Reader The reader site on Calypso.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants