Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: fix test that opens page template #89057

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Conversation

tbradsha
Copy link
Contributor

@tbradsha tbradsha commented Mar 29, 2024

In WordPress/gutenberg#59792, the FSE page template selection was changed to use the DataViews component.

This PR updates the test that opens the page template editor.

Proposed Changes

I created a new FullSiteEditorDataViewsComponent, as DataViews will eventually be the new page/post listing component as well.

Note that I didn't get build out a ton of functions/specific selectors here, as the DataViews component has been evolving quite quickly, and we don't want to be continually adapting this test. Specifically, I didn't bother targeting the "Edit" button (which is selectively visible) or the actions dropdown (which also has changed several times). Instead I just made the test click the primary field text, which opens the template editor.

Old layout:
image

New layout:
image

Testing Instructions

Run the following from the fix/e2e/new_fse_template_page branch:

yarn workspace wp-e2e-tests build && JETPACK_TARGET=wpcom-deployment yarn workspace wp-e2e-tests test -- test/e2e/specs/fse/fse__temp-smoke-test.ts

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@tbradsha tbradsha requested a review from a team March 29, 2024 17:38
@tbradsha tbradsha self-assigned this Mar 29, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 29, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@tbradsha tbradsha merged commit 8ec240a into trunk Mar 29, 2024
14 checks passed
@tbradsha tbradsha deleted the fix/e2e/new_fse_template_page branch March 29, 2024 18:23
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 29, 2024
jeyip pushed a commit that referenced this pull request Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants