Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photos picker: Media library: Update Google Photos icon #96870

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

bogiii
Copy link
Contributor

@bogiii bogiii commented Nov 28, 2024

Related to pdtkmj-36s-p2#comment-5914

Proposed Changes

  • Add Google Photos icon

Why are these changes being made?

  • Replace generic gridicon

Testing Instructions

  • Go to /media/{SITE_SLUG}
  • Click on external source dropdown
  • Check if there is a google photos icon
Before After
Screenshot 2024-11-28 at 11 03 32 Screenshot 2024-11-28 at 11 03 05
Screenshot 2024-11-28 at 11 03 39 Screenshot 2024-11-28 at 11 03 11

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@bogiii bogiii requested a review from a team November 28, 2024 10:08
@bogiii bogiii self-assigned this Nov 28, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 28, 2024
@bogiii bogiii marked this pull request as ready for review November 28, 2024 10:08
@bogiii bogiii changed the title Photos picker: Media library: Update Google photos icon Photos picker: Media library: Update Google Photos icon Nov 28, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/google-photos-picker-12 on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~366 bytes added 📈 [gzipped])

name   parsed_size           gzip_size
media      +1030 B  (+0.1%)     +366 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~366 bytes added 📈 [gzipped])

name                                               parsed_size           gzip_size
async-load-calypso-post-editor-media-modal             +1030 B  (+0.1%)     +366 B  (+0.1%)
async-load-calypso-post-editor-editor-media-modal      +1030 B  (+0.1%)     +366 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@ouikhuan ouikhuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bogiii bogiii merged commit f52d0ac into trunk Nov 28, 2024
15 checks passed
@bogiii bogiii deleted the update/google-photos-picker-12 branch November 28, 2024 11:51
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 28, 2024
@fditrapani
Copy link
Contributor

Very nice! thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants