Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub action deployment #22

Merged
merged 7 commits into from
Jun 6, 2023
Merged

Add GitHub action deployment #22

merged 7 commits into from
Jun 6, 2023

Conversation

v9n
Copy link
Member

@v9n v9n commented Jun 2, 2023

create sepate build/lint checks and deploy run

build/lint: run on every push to ensure the code is build-adable. we don't have any unit test at this moment. just relying on linting and manul test for now.

deploy: normal strategy with staging=staging branch and production=main branch

We were sharing the same domain and use Accept header to route to
GraphiQL or the GraphQL server.

Now we splited them to use a deciated API domain for API
@v9n v9n changed the base branch from main to index-collator-related-data June 2, 2023 16:19
@v9n v9n marked this pull request as draft June 2, 2023 16:20
@v9n v9n force-pushed the add-github-action-deployment branch from c6d0d3e to 7096f80 Compare June 5, 2023 10:24
@v9n v9n force-pushed the add-github-action-deployment branch from 6dd8aa4 to 59eea73 Compare June 6, 2023 15:49
@v9n v9n temporarily deployed to staging June 6, 2023 15:49 — with GitHub Actions Inactive
@v9n v9n changed the title [WIP]Add GitHub action deployment dd GitHub action deployment Jun 6, 2023
@v9n v9n marked this pull request as ready for review June 6, 2023 15:55
@v9n v9n changed the title dd GitHub action deployment Add GitHub action deployment Jun 6, 2023
@v9n v9n requested review from chrisli30 and imstar15 June 6, 2023 16:06
@v9n v9n changed the base branch from index-collator-related-data to staging June 6, 2023 17:25
@v9n v9n temporarily deployed to staging June 6, 2023 19:32 — with GitHub Actions Inactive
Copy link
Member

@chrisli30 chrisli30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@v9n v9n merged commit 4b3894c into staging Jun 6, 2023
@v9n v9n deleted the add-github-action-deployment branch November 26, 2023 15:49
v9n added a commit that referenced this pull request Dec 20, 2023
* add dedicate API domain mapping

We were sharing the same domain and use Accept header to route to
GraphiQL or the GraphQL server.

Now we splited them to use a deciated API domain for API

* index block author and validaor event

* pin to latest subql

* code review improvement

* add sentry monitoring

* add github action for deployment

---------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants