-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub action deployment #22
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were sharing the same domain and use Accept header to route to GraphiQL or the GraphQL server. Now we splited them to use a deciated API domain for API
v9n
force-pushed
the
add-github-action-deployment
branch
from
June 5, 2023 10:24
c6d0d3e
to
7096f80
Compare
v9n
force-pushed
the
add-github-action-deployment
branch
from
June 6, 2023 15:14
9ee1581
to
ace1676
Compare
v9n
force-pushed
the
add-github-action-deployment
branch
from
June 6, 2023 15:26
ace1676
to
e86ca91
Compare
v9n
force-pushed
the
add-github-action-deployment
branch
from
June 6, 2023 15:49
6dd8aa4
to
59eea73
Compare
chrisli30
approved these changes
Jun 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
v9n
added a commit
that referenced
this pull request
Dec 20, 2023
* add dedicate API domain mapping We were sharing the same domain and use Accept header to route to GraphiQL or the GraphQL server. Now we splited them to use a deciated API domain for API * index block author and validaor event * pin to latest subql * code review improvement * add sentry monitoring * add github action for deployment ---------
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create sepate build/lint checks and deploy run
build/lint: run on every push to ensure the code is build-adable. we don't have any unit test at this moment. just relying on linting and manul test for now.
deploy: normal strategy with staging=staging branch and production=main branch