Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User theme (light or dark mode) should be an accessible variable #1492

Closed
1 of 6 tasks
AlexandreSajus opened this issue Jul 8, 2024 · 13 comments · Fixed by #2363
Closed
1 of 6 tasks

User theme (light or dark mode) should be an accessible variable #1492

AlexandreSajus opened this issue Jul 8, 2024 · 13 comments · Fixed by #2363
Assignees
Labels
🖰 GUI Related to GUI 🆘 Help wanted Open to participation from the community ✨New feature 🟩 Priority: Low Low priority and doesn't need to be rushed

Comments

@AlexandreSajus
Copy link
Contributor

AlexandreSajus commented Jul 8, 2024

Description

A user on Discord requested this. The user's theme (light or dark mode) should be a callable variable within the code. This way, the dev could have different images displayed according to the current theme (a white background image in light mode and a black background image in dark mode)

Acceptance Criteria

  • Ensure new code is unit tested, and check code coverage is at least 90%.
  • Create related issue in taipy-doc for documentation and Release Notes.
  • Check if a new demo could be provided based on this, or if legacy demos could be benefit from it.
  • Ensure any change is well documented.

Code of Conduct

  • I have checked the existing issues.
  • I am willing to work on this issue (optional)
@AlexandreSajus AlexandreSajus added 🖰 GUI Related to GUI 🆘 Help wanted Open to participation from the community good first issue New-contributor friendly 🟩 Priority: Low Low priority and doesn't need to be rushed ✨New feature labels Jul 8, 2024
@ranjanmangla1
Copy link

would love to work on this @AlexandreSajus. can you assign me this issue?

@jrobinAV jrobinAV removed 🆘 Help wanted Open to participation from the community good first issue New-contributor friendly labels Jul 11, 2024
@jrobinAV
Copy link
Member

@ranjanmangla1 The "Help wanted" and "good first issue" labels have been misused on this issue. The issue has not been validated nor discussed with the maintainer team, yet.

We will discuss it as soon as possible (probably tomorrow) and will let you know if the issue is ok to be assigned.

Thank you for your understanding.

@jrobinAV
Copy link
Member

A priori, it will be implemented as a CSS rule. The documentation should provide an example.

@jrobinAV jrobinAV added 🆘 Help wanted Open to participation from the community hacktoberfest labels Sep 27, 2024
@sOnU1002
Copy link

sOnU1002 commented Oct 2, 2024

hey i would like to work on the issue

@PayalKumari10
Copy link

Hello @jrobinAV ,

I would like to work on this issue and help implement the theme-based image display functionality. My plan is to:

  • Ensure the user's theme (light or dark mode) is stored as a variable in the code.
  • Implement conditional logic to switch between light and dark mode images.
  • Write unit tests to achieve at least 90% code coverage.
  • Document the changes in taipy-doc and consider updating or creating a demo based on this.

Could you please assign this issue to me? Thank you!

@sangram-mkj-01
Copy link

hey, I would like to work on this issue. You can assign this to me.
Thanks

@FlorianJacta
Copy link
Member

I will assign @sOnU1002 as it was the first reply. Thank you for your contribution!

@PayalKumari10, @sangram-mkj-01, there are a lot of issues to take!

@sOnU1002
Copy link

sOnU1002 commented Oct 3, 2024

can u please specify wherei have add the code

@FlorianJacta
Copy link
Member

@FabienLelaquais will know which people in R&D you should talk to

Copy link

quest-bot bot commented Oct 7, 2024

New Quest! image New Quest!

A new Quest has been launched in @Avaiga’s repo.
Merge a PR that solves this issue to loot the Quest and earn your reward.


Some loot has been stashed in this issue to reward the solver!

🗡 Comment @quest-bot embark to check-in for this Quest and start solving the issue. Other solvers will be notified!

⚔️ When you submit a PR, comment @quest-bot loot #1492 to link your PR to this Quest.

Questions? Check out the docs.

Copy link
Contributor

This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines.

@github-actions github-actions bot added the 🥶Waiting for contributor Issues or PRs waiting for a long time label Oct 22, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

This issue has been unassigned automatically because it has been marked as "🥶Waiting for contributor" for more than 14 days with no activity.

@github-actions github-actions bot removed the 🥶Waiting for contributor Issues or PRs waiting for a long time label Nov 6, 2024
@sanketshinde3001
Copy link

@FlorianJacta Should i work on it

@dinhlongviolin1 dinhlongviolin1 self-assigned this Dec 23, 2024
dinhlongviolin1 added a commit that referenced this issue Dec 23, 2024
* Handle bound var theme toggle

* Update taipy/gui/viselements.json

Co-authored-by: Fabien Lelaquais <[email protected]>

---------

Co-authored-by: Fabien Lelaquais <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖰 GUI Related to GUI 🆘 Help wanted Open to participation from the community ✨New feature 🟩 Priority: Low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants