GUI - Frontend Decoupling #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinhlongviolin1
added
🖰 GUI
dinhlongviolin1
changed the title
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 80.62% (+0.09% 🔼) |
2296/2848 |
| 🟡 | Branches | 62.23% (-0.58% 🔻) |
1415/2274 |
| 🟡 | Functions | 74.72% (-0.28% 🔻) |
399/534 |
| 🟢 | Lines | 80.99% (+0.1% 🔼) |
2130/2630 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | context/wsUtils.ts | 50% | 0% | 0% | 42.86% |
| 🟢 | context/utils.ts | 100% | 70% | 100% | 100% |
| 🟢 | ... / Dialog.tsx |
80.43% | 60.87% | 100% | 80.43% |
| 🟡 | ... / TaipyRendered.tsx |
66.67% | 17.65% | 50% | 66.67% |
| 🟡 | ... / index.ts |
73.33% | 26.67% | 50% | 72.73% |
| 🟢 | ... / Expandable.tsx |
100% | 85% | 100% | 100% |
| 🟢 | ... / PageContent.tsx |
75% | 100% | 0% | 100% |
| 🟢 | ... / Pane.tsx |
95.12% | 73.81% | 100% | 94.87% |
| 🟢 | ... / Part.tsx |
88% | 64.29% | 75% | 91.3% |
| 🟡 | ... / Unregistered.tsx |
62.5% | 0% | 0% | 60% |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟡 | ... / taipyReducers.ts |
64.87% (+0.05% 🔼) |
58.47% (+1.18% 🔼) |
42.86% (-1.37% 🔻) |
64.38% (+0.33% 🔼) |
Test suite run success
334 tests passing in 36 suites.
Report generated by 🧪jest coverage report action from 726b46d
FredLL-Avaiga
previously approved these changes
Dec 15, 2023
| @@ -38,6 +38,9 @@ const Navigate = ({ to, params, tab, force }: NavigateProps) => { | |||
| navigate(0); | |||
| } else { | |||
| navigate({ pathname: to, search: `?${searchParams.toString()}` }); | |||
There was a problem hiding this comment.
do we want 2 navigate calls ?
There was a problem hiding this comment.
without the empty navigate call, the app would not do a hard reload. Please let me know if you have any other approach
|
|
||
| def __handle_ws_get_variables(self): | ||
| # Get Variables | ||
| self.__pre_render_pages() |
There was a problem hiding this comment.
It is necessary though to ensure that we have access to all variables. We can optimize the performance of the method
FredLL-Avaiga
previously approved these changes
Jan 15, 2024
dinhlongviolin1
dismissed stale reviews from FredLL-Avaiga and FabienLelaquais
via
8fd9521
FredLL-Avaiga
approved these changes
Jan 16, 2024
FabienLelaquais
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #446 .
Resolves #656.