-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introdcue font collections #10455
Introdcue font collections #10455
Conversation
62e5ab1
to
67e6ba4
Compare
…d/Avalonia into feature/fontCollections
You can test this PR using the following package version. |
Introduce WithInterFont extension method
You can test this PR using the following package version. |
You can test this PR using the following package version. |
@Gillibald tests are randomly failing because of this PR:
Seems like IAssetLoader needs to be registered in the scope of each of these tests. It passes probably only if loader was registered by some another test (which is also a problem, as all locator registrations in tests should be done in locator scope and cleared after the test). |
Or a mock of asset loader should be registered. |
Locally on mac and windows that unit test doesnt not cause any jobs to be posted to the dispatcher. Only randomly sometimes on CI does it happen.
so this code path never happens. What would make that code path execute?
|
What does the pull request do?
This PR introduces font collection to be able to manage the lifetime of created glyph typefaces and to be able to load fonts from custom sources. As long as it is possible to obtain a stream of the font file it can be loaded.
Fonts within font collections are referenced via
FontFamily="fonts:CollectionName#FamilyName"
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues