Fix use of CoerceCaretIndex on Text change #2553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindexi
reviewed
May 21, 2019
|
Can you add a unit tests for this? |
grokys
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
fixes exception on clicking in TextBox #2552
What is the current behavior?
Under rare circumstances clicking at the end of a TextBox throws an exception
What is the updated/expected behavior with this PR?
exception free clicking
How was the solution implemented (if it's not obvious)?
The check for \r\n could fail if there was a \r at the end of the Text.
Calls to CoerceCaretIndex were using the previous text on Text changed which I can't believe was intended.
Checklist
Fixed issues
Fixes #2552