GLControl

[kekekeks]

Note there is a bug in ANGLE that prevents us from using stencil buffer on software-rendered DirectX (Microsoft Basic Render Device). I have a patch to fix that, but it will be shipped with our angle nuget separately.

[ahopper]

runs on an elderly windows laptop here, I had to add .0 to the float literals in the shaders and mediump to the shared uDisco and uTime.

[kekekeks]

PR should be ready for review

[gulek]

I used this to embedd libmpv into Avalonia. Worked like a charm, but I had a weird resize issue. The video from mpv would resize, the control would resize, but the visible part would stay exactly the size it was during OnOpenGlInit.
I got it working by binding the texture before resizeing it in OpenGlControlBase.Render:

if (_oldSize != GetPixelSize()) {
    gl.BindTexture(GL_TEXTURE_2D, _texture);
    ResizeTexture(gl);
}

[kekekeks]

@gulek
Do you have the same issue with the teapot example from the control catalog?

[kekekeks]

Ah, it seems that your code changes the current texture binding and doesn't restore it back.
I think we should also reset the texture binding back to zero to avoid unnecessary confusion.

[dfkeenan]

Will this be compatible with libraries like OpenTK (4.0)?

[kekekeks]

@dfkeenan that entirely depends on the library. If it's capable of using an external OpenGL context and external glGetProcAddress and isn't afraid of the context being of different types (EGL for Win32, desktop GL for Linux/OSX), it should work.

[msmshazan]

Isn't it better to use swiftshader (https://swiftshader.googlesource.com/SwiftShader) for ANGLE instead of relying on directx WARP?
https://github.com/google/angle/blob/master/extensions/EGL_ANGLE_software_display.txt
https://github.com/google/angle/blob/master/extensions/EGL_ANGLE_platform_angle_device_type_swiftshader.txt

[kekekeks]

WARP allows interop with other DirectX-based APIs which is kinda important for WPF integration and future support for advanced features like DirectComposition.

[MarchingCube]

Did a quick check of this PR, I would need to see how this affects other custom GPU implementations as well.

[MarchingCube]

This is kinda weird - you derive from DisposableLock but all methods here are just hiding base implementation and it ends up having two different locks.

[kekekeks]

Since DisposableLock class contents are copy-pasted from ManagedDeferredRendererLock, it's most likely an unfinished attempt to extract disposable lock logic to a different class

[MarchingCube]

Missing semicolon after float will cause shader compilation error.

[MarchingCube]

This fails for me on Win32 ANGLE that supports only GLES 2.0.

[danwalmsley]

@MarchingCube has tested it, things were fixed it looks good,

@danwalmsley, @grokys and @kekekeks agreed this is a YOLO merge.