Add TextBlock inlines support #6953

Gillibald · 2021-11-16T07:03:26Z

What does the pull request do?

With updated XamlIl

<TextBlock Margin="10" TextWrapping="Wrap">
	This <Span FontWeight="Bold">is</Span> a
	<Span Background="Silver" Foreground="Maroon">TextBlock</Span>
	with <Span TextDecorations="Underline">several</Span>
	<Span FontStyle="Italic">Span</Span> elements,
	<Span Foreground="Blue">
		using a <Bold>variety</Bold> of <Italic>styles</Italic>
	</Span>.
</TextBlock>

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Added unit tests (if possible)?
Added XML documentation to any related classes?
Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with user documentation

Breaking changes

Obsoletions / Deprecations

Fixed issues

Fixes #3737 #2619

jmacato

just some nits but lgtm! :D

src/Avalonia.Controls/Documents/Bold.cs

src/Avalonia.Controls/Documents/Inline.cs

src/Avalonia.Controls/Documents/InlineCollection.cs

src/Avalonia.Controls/Documents/Italic.cs

src/Avalonia.Controls/Documents/Span.cs

src/Avalonia.Controls/Documents/TextElement.cs

src/Avalonia.Controls/Documents/Underline.cs

robloo · 2021-11-16T17:33:32Z

Question: With this level of support for text formatting do you think it's feasible to start looking at RichTextBox (from WPF) or MarkdownTextBox (from UWP toolkit) control ports? Not asking you to look into it, just do you think it's going to be possible soon?

It would be great to see those controls eventually at least in 3rd party libraries to start and it seems with all your text improvements it's getting close to possible.

Gillibald · 2021-11-16T18:09:48Z

To be able to port RichtTextBox we need #5461 that introduces all the required infrastructure.

MarkdownTextBlock needs InlineUIContainer support. That will be added soon.

src/Avalonia.Controls/Documents/TextElement.cs

workgroupengineering · 2021-11-17T10:48:36Z

src/Avalonia.Controls/Documents/TextElement.cs

+        /// <summary>
+        /// Raises the <see cref="Invalidate"/> event.
+        /// </summary>
+        protected void Invalidate() => Invalidated?.Invoke(this, EventArgs.Empty);


A system of Debouncing could be implemented, so that when there are changes in rapid succession the event is called only once.

Mikolaytis · 2021-11-24T12:56:05Z

Good job, @Gillibald ! Awesome news! I will merge this to our app fork and will provide a feedback from our QA Team in a week or so.

Gillibald · 2021-11-24T15:48:32Z

Please note that XamlX needs to be updated to deal with inlines properly.

Mikolaytis · 2021-12-01T23:40:06Z

In WPF if there is any empty space between Run tags - space is added between inlines.
This PR is missing this, is it intended? To make a space between inlines you have to create a trash Run with space in Text.

Mikolaytis · 2021-12-01T23:48:31Z

Foreground property of Run is not working with DynamicResourceExtension to SolidColorBrush. Foreground in this case are now acquired from parent TextBlock.

robloo · 2021-12-02T00:11:15Z

In WPF if there is any empty space between Run tags - space is added between inlines.

#2619

Gillibald · 2021-12-02T05:28:12Z

I will add some unit tests that use Static/DynamicResource for some inlines properties.

Mikolaytis · 2021-12-10T23:14:18Z

@Gillibald I want to merge your fixes and test them but auto-build is failed. so I'm a bit scarry to invest a time into this.

Gillibald · 2021-12-11T06:40:41Z

The build fails because of one Xaml test that is failing. So it should not affect you.

Mikolaytis · 2021-12-13T22:56:07Z

after merging this into avalonia master - getting crash in control catalog.
here is repro. REason - new hamburger menu...

I fixed this by commenting transitions in a file. Looks like an error in xamlX
We don't use transitions yet so this is not an issue at all for us.

Mikolaytis · 2021-12-14T01:49:21Z

Also here is another bug: xamlil counts comment as content. produces this error (see error msg in the bottom of the screenshot):

to fix this I've removed the comment.

Gillibald · 2021-12-14T05:35:27Z

Thanks for testing. So we need to add a test for comments and get transitions working.

Gillibald · 2021-12-15T15:38:43Z

@Mikolaytis Everything should work now

Mikolaytis · 2021-12-22T22:02:52Z

@Gillibald one more thing is broken We've found - TextAlignment=Right on a textbox now broken. Text Measure looks like returning a 0 width.

Mikolaytis · 2021-12-22T22:04:20Z

also we're still testing and it's possible we will find something more this year.

Gillibald · 2021-12-23T12:26:22Z

@Gillibald one more thing is broken We've found - TextAlignment=Right on a textbox now broken. Text Measure looks like returning a 0 width.

I wonder how that is possible. Will investigate.

avaloniaui-team · 2022-02-22T18:45:04Z

You can test this PR using the following package version. 0.10.999-cibuild0018894-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

avaloniaui-team · 2022-02-23T14:27:48Z

You can test this PR using the following package version. 0.10.999-cibuild0018907-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

avaloniaui-team · 2022-02-23T17:37:14Z

You can test this PR using the following package version. 0.10.999-cibuild0018910-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

avaloniaui-team · 2022-02-23T17:39:04Z

You can test this PR using the following package version. 0.10.999-cibuild0018910-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

Not available at the moment

Whiletru3 · 2022-06-03T12:51:18Z

Is there a chance to backport this in 0.10.x ?
Is there a timeline for 0.11 ? :)

maxkatz6 · 2022-06-03T15:03:26Z

Is there a chance to backport this in 0.10.x ?

No, too many breaking changes to get this work with whole new text layout system.
And we don't backport new big features to the 0.10 anymore to keep it...stable. We are busy with the master branch and 11.0, so we don't need to fix new bugs in the stable branch.

Is there a timeline for 0.11 ? :)

Hopefully, first preview will be in the end of this month or beginning of the next. Expected to get first third party libraries to support this version too.
Nightly builds of 11.0 version is already available, but with no support from third party libraries.

Gillibald force-pushed the feature/textBlockInlines branch 2 times, most recently from e941c1e to 0e398a1 Compare November 16, 2021 08:30

jmacato previously requested changes Nov 16, 2021

View reviewed changes

workgroupengineering reviewed Nov 17, 2021

View reviewed changes

Gillibald force-pushed the feature/textBlockInlines branch from f2c24f2 to 4b89cb6 Compare November 17, 2021 14:49

Gillibald changed the title ~~[WIP] Add TextBlock inlines support~~ Add TextBlock inlines support Nov 17, 2021

Gillibald force-pushed the feature/textBlockInlines branch from 0536858 to eb5ad8e Compare December 15, 2021 15:04

Gillibald force-pushed the feature/textBlockInlines branch from eb5ad8e to 2b9dfc3 Compare December 15, 2021 15:44

Gillibald added the enhancement label Dec 15, 2021

Gillibald force-pushed the feature/textBlockInlines branch from 1862494 to e190f91 Compare February 1, 2022 15:04

Takoooooo added this to the 11.0 milestone Feb 21, 2022

Gillibald force-pushed the feature/textBlockInlines branch from eec8721 to 9e2773e Compare February 22, 2022 18:17

Add TextBlock inlines support

95769ff

Gillibald force-pushed the feature/textBlockInlines branch from 52d78df to 95769ff Compare February 23, 2022 14:01

Gillibald requested a review from a team February 23, 2022 14:09

Merge branch 'master' into feature/textBlockInlines

cce20bc

Gillibald enabled auto-merge February 24, 2022 16:10

danwalmsley approved these changes Feb 24, 2022

View reviewed changes

Gillibald merged commit 237a9a4 into AvaloniaUI:master Feb 24, 2022

Gillibald deleted the feature/textBlockInlines branch February 24, 2022 16:11

sleepyfran mentioned this pull request Oct 7, 2022

RichTextBlock bindings fsprojects/Avalonia.FuncUI#219

Closed

nielsbosma mentioned this pull request Nov 5, 2023

Any plans to replace ColorTextBlock.Avalonia for Avalonia 11 with Runs? whistyun/Markdown.Avalonia#132

Open

hhyyrylainen mentioned this pull request Jan 19, 2024

Redo the feed display with Avalonia rich text Revolutionary-Games/Thrive-Launcher#345

Open

maxkatz6 mentioned this pull request Jan 20, 2024

TextBlock Inlines needs at least some documentation AvaloniaUI/avalonia-docs#324

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add TextBlock inlines support #6953

Add TextBlock inlines support #6953

Gillibald commented Nov 16, 2021 •

edited

Loading

jmacato left a comment

robloo commented Nov 16, 2021

Gillibald commented Nov 16, 2021 •

edited

Loading

workgroupengineering Nov 17, 2021

Mikolaytis commented Nov 24, 2021 •

edited

Loading

Gillibald commented Nov 24, 2021 •

edited

Loading

Mikolaytis commented Dec 1, 2021

Mikolaytis commented Dec 1, 2021

robloo commented Dec 2, 2021 •

edited

Loading

Gillibald commented Dec 2, 2021

Mikolaytis commented Dec 10, 2021 •

edited

Loading

Gillibald commented Dec 11, 2021

Mikolaytis commented Dec 13, 2021 •

edited

Loading

Mikolaytis commented Dec 14, 2021 •

edited

Loading

Gillibald commented Dec 14, 2021

Gillibald commented Dec 15, 2021

Mikolaytis commented Dec 22, 2021

Mikolaytis commented Dec 22, 2021

Gillibald commented Dec 23, 2021

avaloniaui-team commented Feb 22, 2022

avaloniaui-team commented Feb 23, 2022

avaloniaui-team commented Feb 23, 2022

avaloniaui-team commented Feb 23, 2022

Whiletru3 commented Jun 3, 2022

maxkatz6 commented Jun 3, 2022

Add TextBlock inlines support #6953

Add TextBlock inlines support #6953

Conversation

Gillibald commented Nov 16, 2021 • edited Loading

What does the pull request do?

With updated XamlIl

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

jmacato left a comment

Choose a reason for hiding this comment

robloo commented Nov 16, 2021

Gillibald commented Nov 16, 2021 • edited Loading

workgroupengineering Nov 17, 2021

Choose a reason for hiding this comment

Mikolaytis commented Nov 24, 2021 • edited Loading

Gillibald commented Nov 24, 2021 • edited Loading

Mikolaytis commented Dec 1, 2021

Mikolaytis commented Dec 1, 2021

robloo commented Dec 2, 2021 • edited Loading

Gillibald commented Dec 2, 2021

Mikolaytis commented Dec 10, 2021 • edited Loading

Gillibald commented Dec 11, 2021

Mikolaytis commented Dec 13, 2021 • edited Loading

Mikolaytis commented Dec 14, 2021 • edited Loading

Gillibald commented Dec 14, 2021

Gillibald commented Dec 15, 2021

Mikolaytis commented Dec 22, 2021

Mikolaytis commented Dec 22, 2021

Gillibald commented Dec 23, 2021

avaloniaui-team commented Feb 22, 2022

avaloniaui-team commented Feb 23, 2022

avaloniaui-team commented Feb 23, 2022

avaloniaui-team commented Feb 23, 2022

Whiletru3 commented Jun 3, 2022

maxkatz6 commented Jun 3, 2022

Gillibald commented Nov 16, 2021 •

edited

Loading

Gillibald commented Nov 16, 2021 •

edited

Loading

Mikolaytis commented Nov 24, 2021 •

edited

Loading

Gillibald commented Nov 24, 2021 •

edited

Loading

robloo commented Dec 2, 2021 •

edited

Loading

Mikolaytis commented Dec 10, 2021 •

edited

Loading

Mikolaytis commented Dec 13, 2021 •

edited

Loading

Mikolaytis commented Dec 14, 2021 •

edited

Loading