Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update microsoft.identity.client #34

Merged
merged 9 commits into from
Oct 11, 2019
Merged

Update microsoft.identity.client #34

merged 9 commits into from
Oct 11, 2019

Conversation

zohaibhanif
Copy link
Contributor

Issue #28

  • Updated the Microsoft.Identity.Client nuget package to 4.4.0.
  • Also updated the other packages to latest version including Xamarin.Forms, Xamarin.Android, Prism.Forms, Prism.Plugin and Prism.DryIoc.Forms.
  • Tested on Android, it is working properly.

dansiegel
dansiegel requested changes Oct 1, 2019
View reviewed changes
shell/ShellApp/Views/MainPage.xaml Outdated Show resolved Hide resolved
src/AP.AzureADAuth/Services/AuthenticationService.cs Show resolved Hide resolved
src/AP.AzureADAuth/ViewModels/LoginPageViewModel.cs Outdated Show resolved Hide resolved
@zohaibhanif zohaibhanif requested a review from dansiegel October 3, 2019 11:37
@zohaibhanif
Copy link
Contributor Author

@dansiegel I performed R & D on checks failure issues and found a similar issue reported on MSBuildSdkExtras repo.
novotnyllc/MSBuildSdkExtras#178

Updating MSBuildSdkExtras could possibly the solution of it.

dansiegel
dansiegel requested changes Oct 7, 2019
View reviewed changes
Copy link
Member

@dansiegel dansiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dansiegel I performed R & D on checks failure issues and found a similar issue reported on MSBuildSdkExtras repo.
onovotny/MSBuildSdkExtras#178

Updating MSBuildSdkExtras could possibly the solution of it.

I already know exactly why the build is failing... you need to fix the PR based on what I have asked you to do.

shell/ShellApp.iOS/ShellApp.iOS.csproj Outdated Show resolved Hide resolved
src/AP.AzureADAuth/ViewModels/LoginPageViewModel.cs Outdated Show resolved Hide resolved
dansiegel
dansiegel requested changes Oct 9, 2019
View reviewed changes
src/AP.AzureADAuth/ViewModels/LoginPageViewModel.cs Outdated Show resolved Hide resolved
src/AP.AzureADAuth/ViewModels/LoginPageViewModel.cs Show resolved Hide resolved
src/AP.AzureADAuth/ViewModels/LoginPageViewModel.cs Show resolved Hide resolved
shell/ShellApp/Views/MainPage.xaml Outdated Show resolved Hide resolved
shell/ShellApp.iOS/ShellApp.iOS.csproj Outdated Show resolved Hide resolved
Zohaib Hanif added 2 commits October 10, 2019 13:52
Refactored LoginCommand.CanExecute check, fixed space issues and reve…
a70f9b9 
…rted linker behavior

fixes #28
Added global.json file to solution folder
b41779b 
- Removed /2.0.24 in AP.AzureADAuth.csproj file
- Added global.json file in the solution folder
fixes #28
dansiegel
dansiegel approved these changes Oct 11, 2019
View reviewed changes
Copy link
Member

@dansiegel dansiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build is failing due to code signing task

@dansiegel dansiegel merged commit 246e6af into master Oct 11, 2019
@dansiegel dansiegel deleted the Update-Microsoft.Identity.Client branch October 11, 2019 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zohaib-avantipoint zohaib-avantipoint zohaib-avantipoint left review comments

@dansiegel dansiegel dansiegel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zohaibhanif @dansiegel @zohaib-avantipoint