Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: OpenGraph fixes #22

Merged
merged 5 commits into from
Jan 7, 2023
Merged

fix: OpenGraph fixes #22

merged 5 commits into from
Jan 7, 2023

Conversation

justlevine
Copy link
Member

What

This PR fixes several issues when querying nodes for OpenGraph SEO data issues:

  • fix: Prevent duplicate OpenGraph meta tags by clearing RankMath hooks before fetching.
  • fix!: Rename playerStreamContentTypee to playerStreamContentType.
  • fix: Allow OpenGraphTwitter.appCountry to resolve to null.

Why

Addresses (partially) #15 .

How

Testing Instructions

Additional Info

Checklist:

  • My code is tested to the best of my abilities.
  • My code follows the WordPress Coding Standards.
  • My code has proper inline documentation.
  • I have added unit tests to verify the code works as intended.
  • The changes in this PR have been noted in CHANGELOG.md

@justlevine justlevine merged commit 3707cd9 into AxeWP:develop Jan 7, 2023
@justlevine justlevine deleted the fix/duplicate-head-from-uncleared-actions branch January 7, 2023 03:02
@justlevine justlevine mentioned this pull request Jan 7, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@justlevine