Fix gateways builder #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
edomingues
force-pushed
the
fix-gateway-builder
branch
from
b9dc191 to
4a19ec5
Compare
smcvb
requested changes
Dec 21, 2021
There was a problem hiding this comment.
Thanks for providing this fix, @edomingues!
There are, however, two things I'd like to see adjusted:
- I am missing a test for the
DefaultReactorCommandGatewaychanges. Would you mind adding that? - We feel this is a fix worthy of doing a patch release of the Reactor Extension for. To that end, your PR should point to the
axon-reactor-4.5.xbranch, however. Would you mind adjusting the base of your branch for this?
edomingues
force-pushed
the
fix-gateway-builder
branch
from
4a19ec5 to
99d4a38
Compare
smcvb
approved these changes
Dec 22, 2021
|
The build succeeds. The issues lie with the deploy to sonatype that fails because of credentials. Thanks for the effort here, @edomingues! We'll do a release of the Reactor Extension ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a
DefaultReactorQueryGatewayusing its Builder, the Dispatch Interceptors are not registered. The same happens with theDefaultReactorCommandGatewayand Result Handler Interceptors. This PR fixes both.