Add CoffeeLint rules #1899
Merged
Add CoffeeLint rules #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already had a CoffeeScript Lint configuration file, but we weren't using it. We're replacing it with a more basic one.
Just like we do in Ruby.
We always use two spaces as indentation.
houndci-bot
reviewed
Mar 4, 2019
| _paq.push(['setUserId', current_user_id]); | ||
| _paq.push(['setCustomDimension', customDimensionId = 1, customDimensionValue = verification_level]); | ||
| _paq.push(['setUserId', current_user_id]) | ||
| _paq.push(['setCustomDimension', customDimensionId = 1, customDimensionValue = verification_level]) |
There was a problem hiding this comment.
Line exceeds maximum allowed length. Length is 105, max is 100.
| @@ -3,7 +3,7 @@ | |||
|
|
|||
| buildGraph = (el) -> | |||
| url = $(el).data 'graph' | |||
| conf = bindto: el, data: {x: 'x', url: url, mimeType: 'json'}, axis: { x: {type: 'timeseries',tick: { format: '%Y-%m-%d' } }} | |||
| conf = bindto: el, data: { x: 'x', url: url, mimeType: 'json' }, axis: { x: { type: 'timeseries', tick: { format: '%Y-%m-%d' } } } | |||
There was a problem hiding this comment.
Line exceeds maximum allowed length. Length is 134, max is 100.
| App.Banners.update_font_color("#js-banner-title", "#banner_font_color_picker", $(this).val()); | ||
| App.Banners.update_font_color("#js-banner-description", "#banner_font_color_picker", $(this).val()); | ||
| App.Banners.update_font_color("#js-banner-title", "#banner_font_color_picker", $(this).val()) | ||
| App.Banners.update_font_color("#js-banner-description", "#banner_font_color_picker", $(this).val()) |
There was a problem hiding this comment.
Line exceeds maximum allowed length. Length is 107, max is 100.
|
|
||
| $("#banner_font_color").on | ||
| change: -> | ||
| App.Banners.update_font_color("#js-banner-title", "#banner_font_color_picker", $(this).val()); | ||
| App.Banners.update_font_color("#js-banner-description", "#banner_font_color_picker", $(this).val()); | ||
| App.Banners.update_font_color("#js-banner-title", "#banner_font_color_picker", $(this).val()) |
There was a problem hiding this comment.
Line exceeds maximum allowed length. Length is 101, max is 100.
|
|
||
| $("#banner_background_color").on | ||
| change: -> | ||
| App.Banners.update_background_color("#js-banner-background", "#banner_background_color_picker", $(this).val()); | ||
| App.Banners.update_background_color("#js-banner-background", "#banner_background_color_picker", $(this).val()) |
There was a problem hiding this comment.
Line exceeds maximum allowed length. Length is 118, max is 100.
| @@ -26,18 +26,18 @@ App.Banners = | |||
|
|
|||
| $("#banner_background_color_picker").on | |||
| change: -> | |||
| App.Banners.update_background_color("#js-banner-background", "#banner_background_color", $(this).val()); | |||
| App.Banners.update_background_color("#js-banner-background", "#banner_background_color", $(this).val()) | |||
There was a problem hiding this comment.
Line exceeds maximum allowed length. Length is 111, max is 100.
decabeza
approved these changes
Mar 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives
Does this PR need a Backport to CONSUL?
Yes.
Notes
As we do in the rest of the code, we're adding a rule setting the max line length to 100 characters, but we're not updating existing code in order to follow that rule.