Remove system recounts in the admin section #2036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 3, 2019
javierm
force-pushed
the
remove_system_total
branch
from
46a5666 to
06e868c
Compare
javierm
changed the title
javierm
changed the title
javierm
force-pushed
the
remove_system_total
branch
from
06e868c to
b570972
Compare
javierm
changed the title
javierm
force-pushed
the
remove_system_total
branch
from
b570972 to
c3cfc90
Compare
houndci-bot
reviewed
Jun 7, 2019
javierm
force-pushed
the
remove_system_total
branch
2 times, most recently
from
99ec068 to
03663c1
Compare
javierm
changed the title
voodoorai2000
approved these changes
Jun 11, 2019
System count isn't a relevant number because the important one is the number of votes counted by poll officers. We're still maintaining it for a month in case poll officers would like to review the results.
Now the code is the same as the code in the poll booth assignment page.
This number was not the important one; the important one is the one given by the recounts. Note we're also removing the votes by date, since they're also system votes.
javierm
force-pushed
the
remove_system_total
branch
from
03663c1 to
a71f96a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
In the past, we had two numbers to track the total numbers of votes in a booth; what we called "final" recounts and "system" recounts. However, sytem recounts are not relevant anymore.
Objectives
Visual Changes
Before these changes:
After these changes:
Does this PR need a Backport to CONSUL?
Yes.