Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5 of 5] Completed the person form on admin/people #178

Conversation

raul-fuentes
Copy link
Contributor

@raul-fuentes raul-fuentes commented May 23, 2018

Where

What

  • Since it is a very large pr I have divided it into 5 consecutive parts (although only the latter must merge)
  • In the other 4, each of the changes needed to resolve the issue is explained in depth
  • In the latter only the form is completed with sections that behave and are programmed in the same way as the 'public activities' section of Activities declarations
  • Completed the assets and activities tabs with the remaining sections
    • Activities declaration
      • private activities
      • other activities
    • Assets declaration
      • real estate properties
      • account deposits
      • other deposits
      • vehicles
      • other personal properties
      • debts
      • tax data

How

  • As explained in depth here, each section is divided in 3 commits specs, views and code (model, controller and helper)

Screenshots

peek 2018-05-14 16-24

Test

  • Added test to cover all the new features and changes, but there are some problems with foundation abide plugin. When the abide plugin its enabled on each form header (on edit and new) capybara fails to submit the form; it becomes empy and the validations prevents the form to be submitted and the test fails.
    If 'data-abide' => '' is removed from the form on edit.html.erb and new.html.erb the commented test works fine but the one wich checks the validations fails
    I can't find a solution an there is little information about that (at least I can't find it)

Deployment

  • No

Warnings

  • ⚠️ This PR should be merged, is the last one for this issue and contains the complete solution for it, the other four explain in detail the solution ⚠️

@coveralls
Copy link

coveralls commented May 23, 2018

Coverage Status

Coverage increased (+2.1%) to 93.485% when pulling 1c334080ddff37a8c5ea31372421315741413d2c on wairbut-m2c:complete_the_admin_person_form into 1e0ffeb30d1bb8db07b2daa6278927e91bda9c72 on AyuntamientoMadrid:master.

@raul-fuentes raul-fuentes force-pushed the complete_the_admin_person_form branch 2 times, most recently from e38e313 to 1c33408 Compare June 25, 2018 07:42
@MariaCheca MariaCheca changed the base branch from master to feature/profiles June 27, 2018 17:35
@MariaCheca MariaCheca merged this pull request into AyuntamientoMadrid:feature/profiles Jun 27, 2018
This was referenced Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants