Skip to content

Commit

Permalink
[NO CI] nuking obsolete test
Browse files Browse the repository at this point in the history
  • Loading branch information
benesjan committed Feb 11, 2025
1 parent fc7f4e3 commit 0507165
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 15 deletions.
2 changes: 0 additions & 2 deletions noir-projects/aztec-nr/aztec/src/note/note_getter/mod.nr
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,6 @@ where
prev_fields = fields;

let note_hash_for_read_request = compute_note_hash_for_read_request(note, storage_slot);
// TODO(https://github.com/AztecProtocol/aztec-packages/issues/1410): test to ensure
// failure if malicious oracle injects 0 nonce here for a "pre-existing" note.
context.push_note_hash_read_request(note_hash_for_read_request);
note_hashes.push(note_hash_for_read_request);
};
Expand Down
13 changes: 0 additions & 13 deletions noir-projects/aztec-nr/aztec/src/note/note_getter/test.nr
Original file line number Diff line number Diff line change
Expand Up @@ -168,19 +168,6 @@ unconstrained fn applies_filter_before_constraining() {
assert_eq(context.note_hash_read_requests.len(), 1);
}

#[test(should_fail_with = "Mismatch note header contract address.")]
unconstrained fn rejects_mismatched_address() {
let mut env = setup();
let mut context = env.private();

let note = MockNote::new(1).build(); // We're not setting the right contract address
let mut opt_notes = [Option::none(); MAX_NOTE_HASH_READ_REQUESTS_PER_CALL];
opt_notes[0] = Option::some(note);

let mut options = NoteGetterOptions::new();
let _ = constrain_get_notes_internal(&mut context, storage_slot, opt_notes, options);
}

#[test(should_fail_with = "Mismatch note header storage slot.")]
unconstrained fn rejects_mismatched_storage_slot() {
let mut env = setup();
Expand Down

0 comments on commit 0507165

Please sign in to comment.