address PR feedback

AztecProtocol · Feb 29, 2024 · 63da191 · 63da191
1 parent ceaf261
commit 63da191
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 14 deletions.
diff --git a/yarn-project/circuits.js/src/structs/kernel/combined_accumulated_data.ts b/yarn-project/circuits.js/src/structs/kernel/combined_accumulated_data.ts
@@ -32,8 +32,6 @@ import { NullifierKeyValidationRequestContext } from '../nullifier_key_validatio
 import { SideEffect, SideEffectLinkedToNoteHash } from '../side_effects.js';
 import { NewContractData } from './new_contract_data.js';
 
-// const log = createDebugLogger('aztec:combined_accumulated_data');
-
 /**
  * Read operations from the public state tree.
  */
@@ -331,11 +329,6 @@ export class CombinedAccumulatedData {
       ...nonRevertible.publicDataUpdateRequests,
     ].filter(x => !x.isEmpty());
 
-    // log.debug('nonSquashedWrites');
-    // for (const write of nonSquashedWrites) {
-    //   log.debug(write.toFriendlyJSON());
-    // }
-
     const squashedWrites = Array.from(
       nonSquashedWrites
         .reduce<Map<string, PublicDataUpdateRequest>>((acc, curr) => {
@@ -345,11 +338,6 @@ export class CombinedAccumulatedData {
         .values(),
     );
 
-    // log.debug('squashedWrites');
-    // for (const write of squashedWrites) {
-    //   log.debug(write.toFriendlyJSON());
-    // }
-
     const publicDataUpdateRequests = padArrayEnd(
       squashedWrites,
       PublicDataUpdateRequest.empty(),

diff --git a/yarn-project/noir-contracts.js/package.json b/yarn-project/noir-contracts.js/package.json
@@ -49,4 +49,4 @@
   "engines": {
     "node": ">=18"
   }
-}
+}
diff --git a/yarn-project/sequencer-client/src/sequencer/public_processor.test.ts b/yarn-project/sequencer-client/src/sequencer/public_processor.test.ts
@@ -359,7 +359,8 @@ describe('public_processor', () => {
         proof,
         TxL2Logs.random(2, 3),
         TxL2Logs.random(3, 2),
-        callRequests.slice().reverse(), // unsure why we need to reverse here 😬
+        // reverse because `enqueuedPublicFunctions` expects the last element to be the front of the queue
+        callRequests.slice().reverse(),
         [ExtendedContractData.random()],
       );
-Original file line number
+Diff line change
@@ Expand Up / @@ -49,4 +49,4 @@ @@
       "engines": {
         "node": ">=18"
       }
-    }
+    }