chore: address comments

AztecProtocol · Apr 17, 2024 · 804646b · 804646b
1 parent bae0aa1
commit 804646b
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/yarn-project/circuit-types/src/tx/simulated_tx.ts b/yarn-project/circuit-types/src/tx/simulated_tx.ts
@@ -17,7 +17,7 @@ export class SimulatedTx {
    */
   public toJSON() {
     const returnToJson = (data: ProcessReturnValues | undefined): string => {
-      if (data == undefined) {
+      if (data === undefined) {
         return JSON.stringify(data);
       }
       return JSON.stringify(data.map(fr => fr.toString()));
@@ -37,7 +37,7 @@ export class SimulatedTx {
    */
   public static fromJSON(obj: any) {
     const returnFromJson = (json: string): ProcessReturnValues | undefined => {
-      if (json == undefined) {
+      if (json === undefined) {
         return json;
       }
       return JSON.parse(json).map(Fr.fromString);

diff --git a/yarn-project/pxe/src/pxe_service/pxe_service.ts b/yarn-project/pxe/src/pxe_service/pxe_service.ts
@@ -417,7 +417,6 @@ export class PXEService implements PXE {
       }
 
       if (simulatePublic) {
-        // Only one transaction, so we can take index 0.
         simulatedTx.publicReturnValues = await this.#simulatePublicCalls(simulatedTx.tx);
       }
 

diff --git a/yarn-project/types/src/abi/contract_artifact.ts b/yarn-project/types/src/abi/contract_artifact.ts
@@ -136,7 +136,7 @@ function generateFunctionArtifact(fn: NoirCompiledContractFunction, contract: No
   }
 
   let returnTypes: AbiType[] = [];
-  if (functionType == FunctionType.UNCONSTRAINED && fn.abi.return_type) {
+  if (functionType === FunctionType.UNCONSTRAINED && fn.abi.return_type) {
     returnTypes = [fn.abi.return_type.abi_type];
   } else {
     const pathToFind = `${contract.name}::${fn.name}_abi`;
-Original file line number
+Diff line change
@@ Expand Up / @@ -417,7 +417,6 @@ export class PXEService implements PXE { @@
           }
           if (simulatePublic) {
-            // Only one transaction, so we can take index 0.
             simulatedTx.publicReturnValues = await this.#simulatePublicCalls(simulatedTx.tx);
           }
@@ Expand Down @@