feat: new key store

noir-projects/aztec-nr/aztec/src/note/utils.nr

@@ -71,8 +71,8 @@ pub fn compute_note_hash_for_consumption<Note, N>(note: Note) -> Field where Not
     } else {
         // When nonce is nonzero, that means we are reading a settled note (from tree) created in a
         // previous TX. So we need the unique_siloed_note_hash which has already been hashed with
-        // contract address and then nonce. This hash will match the existing leaf in the private
-        // data tree, so the kernel can just perform a membership check directly on this hash/leaf.
+        // contract address and then nonce. This hash will match the existing leaf in the note hash
+        // tree, so the kernel can just perform a membership check directly on this hash/leaf.
         compute_unique_siloed_note_hash(note)
         // IMPORTANT NOTE ON REDUNDANT SILOING BY CONTRACT ADDRESS: The note hash computed above is
         // "siloed" by contract address. When a note hash is computed solely for the purpose of
@@ -81,7 +81,7 @@ pub fn compute_note_hash_for_consumption<Note, N>(note: Note) -> Field where Not
         // be computed from a siloed note hash. After all, persistable note hashes and nullifiers are
         // siloed by the kernel circuit. That being said, the siloed note hash computed above CAN be
         // used for nullifier computation, and this achieves the (arguably unnecessary) property that
-        // nullifiers are computed from a note hash's fully-computed private data tree leaf.
+        // nullifiers are computed from a note hash's fully-computed note hash tree leaf.
     }
 }
 

yarn-project/circuit-types/src/keys/key_store.ts

@@ -3,6 +3,7 @@ import { type AztecAddress, type GrumpkinPrivateKey, type PublicKey } from '@azt
 /**
  * Represents a secure storage for managing keys.
  * Provides functionality to create and retrieve accounts, private and public keys,
+ * TODO(#5627): 💣💣💣
  */
 export interface KeyStore {
   /**

yarn-project/circuit-types/src/keys/new_key_store.ts

@@ -0,0 +1,36 @@
+import { type PublicKey } from '@aztec/circuits.js';
+
+/**
+ * Represents a secure storage for managing keys.
+ */
+export interface NewKeyStore {
+  /**
+   * Retrieves the master nullifier public key.
+   * @returns A Promise that resolves to the master nullifier public key.
+   */
+  getMasterNullifierPublicKey(): Promise<PublicKey>;
+
+  /**
+   * Retrieves the master incoming viewing key.
+   * @returns A Promise that resolves to the master incoming viewing key.
+   */
+  getMasterIncomingViewingPublicKey(): Promise<PublicKey>;
+
+  /**
+   * Retrieves the master outgoing viewing key.
+   * @returns A Promise that resolves to the master outgoing viewing key.
+   */
+  getMasterOutgoingViewingPublicKey(): Promise<PublicKey>;
+
+  /**
+   * Retrieves the master tagging key.
+   * @returns A Promise that resolves to the master tagging key.
+   */
+  getMasterTaggingPublicKey(): Promise<PublicKey>;
+
+  /**
+   * Retrieves the hash of the public keys.
+   * @returns A Promise that resolves to the hash of the public keys.
+   */
+  getPublicKeysHash(): Promise<PublicKey>;
+}

yarn-project/key-store/src/test_key_store.ts

@@ -16,6 +16,7 @@ import { ConstantKeyPair } from './key_pair.js';
 /**
  * TestKeyStore is an implementation of the KeyStore interface, used for managing key pairs in a testing environment.
  * It should be utilized in testing scenarios where secure key management is not required, and ease-of-use is prioritized.
+ * TODO(#5627): 💣💣💣
  */
 export class TestKeyStore implements KeyStore {
   #keys: AztecMap<string, Buffer>;