Skip to content

Commit

Permalink
fix: use correct size for databus_id (#10673)
Browse files Browse the repository at this point in the history
Apparently at the time the below issue was created things failed if we
used the correct limited size for the databus_id poly. Maybe we made a
mistake then or maybe something got fixed somewhere but either way it
works fine now.

Closes AztecProtocol/barretenberg#1107
  • Loading branch information
ledwards2225 authored and Maddiaa0 committed Dec 13, 2024
1 parent 693b5c2 commit e97194a
Showing 1 changed file with 1 addition and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -177,11 +177,7 @@ template <IsUltraFlavor Flavor> class DeciderProvingKey_ {
proving_key.polynomials.return_data_read_tags =
Polynomial(MAX_DATABUS_SIZE, proving_key.circuit_size);

// TODO(https://github.com/AztecProtocol/barretenberg/issues/1107): Restricting databus_id to
// databus_size leads to failure.
// const size_t databus_size = std::max({ calldata.size(), secondary_calldata.size(),
// return_data.size() });
proving_key.polynomials.databus_id = Polynomial(proving_key.circuit_size, proving_key.circuit_size);
proving_key.polynomials.databus_id = Polynomial(MAX_DATABUS_SIZE, proving_key.circuit_size);
}
const size_t max_tables_size =
std::min(static_cast<size_t>(MAX_LOOKUP_TABLES_SIZE), dyadic_circuit_size - 1);
Expand Down

0 comments on commit e97194a

Please sign in to comment.