Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(aztec-spartan): tests should not depend on live network #10809

Closed
just-mitch opened this issue Dec 17, 2024 · 0 comments
Closed

chore(aztec-spartan): tests should not depend on live network #10809

just-mitch opened this issue Dec 17, 2024 · 0 comments
Assignees
@signorecello

Comments

@just-mitch
Copy link
Collaborator

just-mitch commented Dec 17, 2024 •
edited
Loading

We need the earthly tests to support supplying an env with all the contract addresses so we don't need to reach out to a (potentially down) node to get the values.

See #10810
@just-mitch just-mitch mentioned this issue Dec 17, 2024
Merged
just-mitch added a commit that referenced this issue Dec 17, 2024
@just-mitch
chore: update external joiner script for new networks (#10810)
5f11cf4 
The script now takes an explicit reference to a network.

Networks have hardcoded configurations to loadbalancers that sit in
front of boot-nodes and the ethereum host.

For now, only `troll-turtle` is supported. Users can override to join
custom networks by setting.

Note: this means that if the `troll-turtle` network goes down, these
test will fail.

I'm fine with that for now, but I filed
#10809
@just-mitch just-mitch closed this as not planned Won't fix, can't repro, duplicate, stale Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@signorecello signorecello

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@signorecello @just-mitch