Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix safety warnings in noir-protocol-circuits #11251

Closed
benesjan opened this issue Jan 15, 2025 · 0 comments · Fixed by #11269 or #11803
Closed

Fix safety warnings in noir-protocol-circuits #11251

benesjan opened this issue Jan 15, 2025 · 0 comments · Fixed by #11269 or #11803

Comments

@benesjan
Copy link
Contributor

Safety warnings need to be fixed as soon they will become a compilation error.

Followup of this issue in which I fixed warnings in Aztec.nr and in noir contracts.
@benesjan benesjan mentioned this issue Jan 15, 2025
Closed
@MirandaWood MirandaWood mentioned this issue Jan 16, 2025
Merged
@MirandaWood MirandaWood reopened this Jan 16, 2025
@MirandaWood MirandaWood mentioned this issue Feb 7, 2025
Merged
TomAFrench pushed a commit that referenced this issue Feb 11, 2025
@MirandaWood
chore: remove warnings from noir protocol circuits (#11803)
c6cc3d3 
Closes #11251

Unfortunately there is a single warning left due to visibility for
`U128.lo` and `U128.hi`. We use this extensively in some contracts via a
macro.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@benesjan @MirandaWood