Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: staking library #11559

Merged
merged 1 commit into from
Feb 4, 2025
Merged

feat!: staking library #11559

merged 1 commit into from
Feb 4, 2025

Conversation

LHerskind
Copy link
Contributor

@LHerskind LHerskind commented Jan 28, 2025

Fixes #11519. Minor oddities can be encountered, if the events are in the library, they won't be part of the rollup contract since the library is external. Therefore events and structs are kept in the interface for simple access.

Copy link
Contributor Author

LHerskind commented Jan 28, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@LHerskind LHerskind mentioned this pull request Jan 28, 2025
@LHerskind LHerskind force-pushed the lh/11520 branch 2 times, most recently from f3e264f to f4e5f8d Compare January 29, 2025 13:58
@LHerskind LHerskind marked this pull request as ready for review January 29, 2025 16:42
Base automatically changed from lh/11520 to master February 3, 2025 14:24

bytes32 private constant STAKING_SLOT = keccak256("aztec.core.staking.storage");

function initialize(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little strange this is ordered differently to the initialize args order

Copy link
Member

@Maddiaa0 Maddiaa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me but now needs rebase

@LHerskind LHerskind merged commit c050320 into master Feb 4, 2025
53 checks passed
@LHerskind LHerskind deleted the lh/11519 branch February 4, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: staking library
2 participants