feat!: time library #11542
Open
feat!: time library #11542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Docs PreviewHey there! 👋 You can check your preview at https://679d0913468847339beba7f0--aztec-docs-dev.netlify.app |
LHerskind
force-pushed
the
lh/11520
branch
2 times, most recently
from
0a1c48b to
038f085
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #11520. Moves the time math back into a library with access to storage. Alters a few getters to make it less leaky around the immutability or the vars (thereby breaking for nodes depending on those):
GENESIS_TIME() -> getGenesisTime()SLOT_DURATION() -> getSlotDuration()EPOCH_DURATION() -> getEpochDuration()Keeps bunch of the time math separate though, mainly the things related to conversion between the types. By moving the genesis into that library storage as well, we can get a more clean api, for example cases where we would previously pass
ts - GENESIS_TIMEneed only pass alongtsandGENESIS_TIMEis only in that library.Should make it simpler to deal with #11519 and #11521 now.
Diff looks bigish because a lot of imports are now
TimeLibinstead ofTimeMath.