Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVM: external call success value tag should be U1 #8998

Closed
Tracked by #9059
jeanmon opened this issue Oct 3, 2024 · 0 comments · Fixed by #9551
Closed
Tracked by #9059

AVM: external call success value tag should be U1 #8998

jeanmon opened this issue Oct 3, 2024 · 0 comments · Fixed by #9551
Assignees
@dbanks12
Labels
C-avm Component: AVM related tickets (aka public VM)

Comments

@jeanmon
Copy link
Contributor

jeanmon commented Oct 3, 2024 •
edited
Loading

In trace.cpp, this line of code in constrain_external_call():

write_slice_to_memory(resolved_success_offset, AvmMemoryTag::U8, std::vector<FF>{ hint.success });

needs to be U1.

Simulator relevant code:
https://github.com/AztecProtocol/aztec-packages/blob/master/yarn-project/simulator/src/avm/opcodes/external_calls.ts#L120
@jeanmon jeanmon added this to A3 Oct 3, 2024
@jeanmon jeanmon self-assigned this Oct 3, 2024
@jeanmon jeanmon converted this from a draft issue Oct 3, 2024
@jeanmon jeanmon added the C-avm Component: AVM related tickets (aka public VM) label Oct 3, 2024
@jeanmon jeanmon assigned dbanks12 and unassigned jeanmon Oct 3, 2024
@dbanks12 dbanks12 mentioned this issue Oct 7, 2024
Closed
@fcarreiro fcarreiro mentioned this issue Oct 29, 2024
Merged
fcarreiro added a commit that referenced this issue Oct 29, 2024
@fcarreiro
feat(avm)!: cleanup CALL (#9551)
26adc55 
* (Static)CALL now returns just the success bit
* Properly returns U1 instead of U8
* Removed FunctionSelector

Fixes #8998. Part of #9061.
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbanks12 dbanks12

Labels
C-avm Component: AVM related tickets (aka public VM)
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(avm)!: cleanup CALL AztecProtocol/aztec-packages
2 participants
@dbanks12 @jeanmon