Rk/clean collect logs #1026
Merged
Rk/clean collect logs #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul-kothari
force-pushed
the
rk/clean_collect_logs
branch
from
40c81fa to
497af6f
Compare
jeanmon
approved these changes
Jul 11, 2023
| }); | ||
|
|
||
| it('collect unencrypted logs with multiple logs each function call', () => { | ||
| /* |
There was a problem hiding this comment.
I would rephrase the name of this test as fnA and fnB do not emit logs. Maybe sthg like:
'collect unencrypted logs with multiple logs in each function call leaves'
spalladino
approved these changes
Jul 11, 2023
rahul-kothari
force-pushed
the
rk/clean_collect_logs
branch
from
497af6f to
9369285
Compare
rahul-kothari
force-pushed
the
rk/clean_collect_logs
branch
from
9369285 to
ad99dfd
Compare
6 tasks
suyash67
added a commit
that referenced
this pull request
Aug 18, 2023
# Description Multi-transfer contract demonstrates upto 12 transfers per transaction for applications like payroll. We add two e2e tests, one that spends notes to transfer tokens to 12 unique recipients, other that splits a single note into 12 smaller denomination notes. The second test also tests creation and spending of value notes in the same transaction. Co-credit: @rahul-kothari, @jeanmon, @Cooper-Kunz, @jfecher. Thanks to @LeilaWang for helping fix `get_balance` in aztec-noir. Also resolves #987 (This PR ensures that we emit different unencrypted logs in the same transaction, @rahul-kothari wrote specific execution tests for this issue in #1026) # Checklist: - [x] I have reviewed my diff in github, line by line. - [x] Every change is related to the PR description. - [x] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to the issue(s) that it resolves. - [x] There are no unexpected formatting changes, superfluous debug logs, or commented-out code. - [x] The branch has been merged or rebased against the head of its merge target. - [x] I'm happy for the PR to be merged at the reviewer's next convenience. --------- Co-authored-by: Rahul Kothari <[email protected]>
superstar0402
added a commit
to superstar0402/aztec-nr
that referenced
this pull request
Aug 16, 2024
# Description Multi-transfer contract demonstrates upto 12 transfers per transaction for applications like payroll. We add two e2e tests, one that spends notes to transfer tokens to 12 unique recipients, other that splits a single note into 12 smaller denomination notes. The second test also tests creation and spending of value notes in the same transaction. Co-credit: @rahul-kothari, @jeanmon, @Cooper-Kunz, @jfecher. Thanks to @LeilaWang for helping fix `get_balance` in aztec-noir. Also resolves AztecProtocol/aztec-packages#987 (This PR ensures that we emit different unencrypted logs in the same transaction, @rahul-kothari wrote specific execution tests for this issue in AztecProtocol/aztec-packages#1026) # Checklist: - [x] I have reviewed my diff in github, line by line. - [x] Every change is related to the PR description. - [x] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to the issue(s) that it resolves. - [x] There are no unexpected formatting changes, superfluous debug logs, or commented-out code. - [x] The branch has been merged or rebased against the head of its merge target. - [x] I'm happy for the PR to be merged at the reviewer's next convenience. --------- Co-authored-by: Rahul Kothari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have updated it with your comments - so feel free to just review the 2nd commit
Stack is basically a queue in a reverse order. So doing what santiago originally did but adding a .reverse() would work.
Added some tests
Please sanity check that the ordering I have written in the tests are similar to what you would expect from ACVM or kernel
Checklist: