-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First test of sandbox e2e #1078
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Do we think we can now delete yarn-project/aztec-sandbox/src/examples/uniswap_trade_on_l1_from_l2.ts
and just bring in that logic from the e2e test?
@@ -81,6 +92,7 @@ async function main() { | |||
|
|||
main() | |||
.then(() => logger(`Aztec JSON RPC listening on port ${SERVER_PORT}`)) | |||
.then(() => logger(`${splash}\n${github}\n\n`)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fancy!
Description
This PR modifies all e2e tests so that they can be run directly against the sandbox environment. It also includes an additional CI step that runs the uniswap e2e test against a deployed sandbox.
Checklist: