Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First test of sandbox e2e #1078

Merged
merged 57 commits into from
Jul 20, 2023
Merged

First test of sandbox e2e #1078

merged 57 commits into from
Jul 20, 2023

Conversation

PhilWindle
Copy link
Collaborator

@PhilWindle PhilWindle commented Jul 14, 2023

Description

This PR modifies all e2e tests so that they can be run directly against the sandbox environment. It also includes an additional CI step that runs the uniswap e2e test against a deployed sandbox.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@PhilWindle PhilWindle marked this pull request as ready for review July 15, 2023 20:03
@PhilWindle PhilWindle enabled auto-merge (squash) July 20, 2023 17:26
Copy link
Collaborator

@spalladino spalladino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Do we think we can now delete yarn-project/aztec-sandbox/src/examples/uniswap_trade_on_l1_from_l2.ts and just bring in that logic from the e2e test?

@@ -81,6 +92,7 @@ async function main() {

main()
.then(() => logger(`Aztec JSON RPC listening on port ${SERVER_PORT}`))
.then(() => logger(`${splash}\n${github}\n\n`))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fancy!

@PhilWindle PhilWindle merged commit d919151 into master Jul 20, 2023
@PhilWindle PhilWindle deleted the pw/sandbox-test branch July 20, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants