Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: static ip for dashboard #11044

Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

feat: static ip for dashboard #11044

wants to merge 34 commits into from
+286 −120

Conversation

just-mitch
Copy link
Collaborator

@just-mitch just-mitch commented Jan 3, 2025 •
edited
Loading

Plus:

  • more replicas for the prometheus server
  • a constant password, kept in google secret manager

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025 •
edited
Loading

Changes to public function bytecode sizes

Generated at commit: 6534c073af9992e57a0ae591d6d876c1c2dc7ee3, compared to commit: f4e2953632ad4fdcf0a6cf00eda4b16b4b3db0f2

🧾 Summary (100% most significant diffs)

Program Bytecode size in bytes (+/-) %
Crowdfunding::_publish_donation_receipts +532 ❌ +145.36%
TestLog::emit_unencrypted_events +333 ❌ +43.70%
AvmTest::assertion_failure +52 ❌ +31.90%
TestLog::public_dispatch +474 ❌ +27.54%
AvmTest::returndata_copy_oracle +338 ❌ +24.35%
Test::emit_public +263 ❌ +23.15%
Lending::get_assets +43 ❌ +11.05%
AvmTest::emit_public_log +258 ❌ +10.79%
Crowdfunding::public_dispatch +331 ❌ +8.11%
Uniswap::_approve_bridge_and_exit_input_asset_to_L1 +498 ❌ +7.53%
StaticChild::public_dispatch +131 ❌ +6.91%
CardGame::on_game_joined +338 ❌ +6.44%
AvmTest::get_args_hash +101 ❌ +5.87%
Parent::pub_entry_point_twice +46 ❌ +4.82%
Child::public_dispatch +211 ❌ +4.65%
Token::burn_public +170 ❌ +4.12%
NFT::transfer_in_public +133 ❌ +3.96%
Child::set_value_with_two_nested_calls +33 ❌ +3.53%
DocsExample::public_dispatch +117 ❌ +3.22%
AMM::_swap_exact_tokens_for_tokens +164 ❌ +2.95%
Benchmarking::public_dispatch +97 ❌ +2.90%
EasyPrivateVoting::public_dispatch +132 ❌ +2.87%
AMM::_swap_tokens_for_exact_tokens +172 ❌ +2.75%
Lending::repay_public +72 ❌ +2.73%
Lending::deposit_public +72 ❌ +2.60%
AvmTest::read_storage_map +39 ❌ +2.60%
AuthRegistry::is_reject_all +39 ❌ +2.53%
NFT::is_minter +39 ❌ +2.44%
AuthRegistry::set_reject_all +35 ❌ +2.34%
StatefulTest::get_public_value +34 ❌ +2.22%
NFT::_finish_transfer_to_public +35 ❌ +2.21%
NFT::set_minter +35 ❌ +2.19%
Token::is_minter +34 ❌ +2.13%
PriceFeed::set_price +32 ❌ +2.10%
AvmTest::bulk_testing +461 ❌ +2.08%
StatefulTest::increment_public_value_no_init_check +30 ❌ +2.00%
InclusionProofs::public_dispatch +75 ❌ +2.00%
NFT::owner_of +35 ❌ +2.00%
TokenBlacklist::balance_of_public +33 ❌ +1.94%
StatefulTest::increment_public_value +30 ❌ +1.94%
Benchmarking::broadcast +30 ❌ +1.91%
Token::set_minter +30 ❌ +1.88%
Lending::update_accumulator +98 ❌ +1.80%
FeeJuice::check_balance +32 ❌ +1.66%
ImportTest::public_dispatch +16 ❌ +1.46%
FeeJuice::balance_of_public +24 ❌ +1.45%
PriceFeed::get_price +24 ❌ +1.45%
Token::balance_of_public +24 ❌ +1.41%
Lending::_repay +73 ❌ +1.38%
AMM::_remove_liquidity +90 ❌ +1.27%
Token::mint_to_public +21 ❌ +0.94%
TokenBlacklist::_increase_public_balance +20 ❌ +0.89%
InclusionProofs::constructor +19 ❌ +0.79%
AMM::constructor +21 ❌ +0.78%
TokenBlacklist::shield +40 ❌ +0.71%
AvmTest::n_storage_writes +9 ❌ +0.58%
Token::transfer_in_public +23 ❌ +0.53%
FPC::pull_funds +14 ❌ +0.51%
TokenBlacklist::_reduce_total_supply +2 ❌ +0.37%
FeeJuice::public_dispatch +15 ❌ +0.33%
Token::_increase_public_balance +3 ❌ +0.14%
CardGame::on_card_played +7 ❌ +0.11%
Spam::public_dispatch -1 ✅ -0.03%
Lending::init -1 ✅ -0.04%
Spam::public_spam -1 ✅ -0.05%
Lending::_withdraw -4 ✅ -0.05%
Lending::_borrow -4 ✅ -0.05%
TokenBlacklist::mint_public -3 ✅ -0.08%
AuthWitTest::public_dispatch -4 ✅ -0.27%
AvmTest::external_call_to_divide_by_zero_recovers -9 ✅ -0.32%
Parent::public_nested_static_call -13 ✅ -0.37%
PriceFeed::public_dispatch -10 ✅ -0.37%
Token::_finalize_transfer_to_private_unsafe -23 ✅ -0.44%
Token::finalize_transfer_to_private -23 ✅ -0.45%
AvmTest::debug_logging -6 ✅ -0.45%
AvmInitializerTest::public_dispatch -12 ✅ -0.45%
StaticParent::public_nested_static_call -10 ✅ -0.47%
Lending::withdraw_public -10 ✅ -0.48%
Lending::borrow_public -10 ✅ -0.48%
EasyPrivateVoting::add_to_tally_public -9 ✅ -0.49%
AvmTest::add_storage_map -9 ✅ -0.53%
AvmTest::set_storage_map -9 ✅ -0.56%
StaticParent::public_dispatch -32 ✅ -0.57%
Benchmarking::increment_balance -13 ✅ -0.59%
Claim::public_dispatch -21 ✅ -0.59%
AvmTest::poseidon2_hash -9 ✅ -0.59%
FPC::pay_refund -16 ✅ -0.60%
AvmInitializerTest::constructor -12 ✅ -0.64%
TokenBlacklist::update_roles -42 ✅ -0.65%
Lending::get_asset -15 ✅ -0.67%
TokenBridge::constructor -18 ✅ -0.67%
FPC::constructor -18 ✅ -0.68%
AvmTest::u128_addition_overflow -9 ✅ -0.69%
Claim::constructor -21 ✅ -0.75%
Auth::constructor -20 ✅ -0.79%
EasyPrivateVoting::constructor -20 ✅ -0.79%
NFT::_finalize_transfer_to_private_unsafe -37 ✅ -0.80%
AvmTest::pedersen_hash_with_index -23 ✅ -0.80%
AvmTest::pedersen_hash -23 ✅ -0.80%
Uniswap::constructor -20 ✅ -0.80%
Auth::public_dispatch -74 ✅ -0.80%
NFT::finalize_transfer_to_private -37 ✅ -0.80%
TokenBlacklist::mint_private -30 ✅ -0.81%
CardGame::start_game -58 ✅ -0.82%
StatefulTest::public_constructor -24 ✅ -0.82%
TokenBlacklist::burn_public -41 ✅ -0.83%
Crowdfunding::init -23 ✅ -0.83%
AvmTest::elliptic_curve_add_and_double -6 ✅ -0.83%
Parent::public_static_call -10 ✅ -0.85%
StaticParent::public_static_call -10 ✅ -0.85%
Lending::_deposit -22 ✅ -0.87%
FeeJuice::_increase_public_balance -18 ✅ -0.94%
CardGame::on_cards_claimed -74 ✅ -0.95%
NFT::_store_payload_in_transient_storage_unsafe -11 ✅ -0.96%
Token::_store_payload_in_transient_storage_unsafe -11 ✅ -0.96%
Token::_finalize_mint_to_private_unsafe -49 ✅ -1.01%
Auth::get_authorized_delay -20 ✅ -1.01%
Token::finalize_mint_to_private -49 ✅ -1.02%
AvmTest::elliptic_curve_add -6 ✅ -1.02%
Test::create_l2_to_l1_message_public -23 ✅ -1.15%
AvmTest::public_dispatch -748 ✅ -1.19%
AvmTest::pedersen_commit -14 ✅ -1.19%
AvmTest::keccak_f1600 -6 ✅ -1.19%
TokenBlacklist::get_roles -34 ✅ -1.26%
AppSubscription::constructor -39 ✅ -1.27%
AvmTest::test_get_contract_instance -6 ✅ -1.29%
AvmTest::test_get_contract_instance_matches -6 ✅ -1.31%
Auth::get_scheduled_authorized -23 ✅ -1.31%
Auth::set_authorized -64 ✅ -1.32%
Uniswap::_assert_token_is_same -10 ✅ -1.33%
Auth::set_authorized_delay -66 ✅ -1.33%
AvmTest::to_radix_le -6 ✅ -1.37%
AvmTest::nested_call_to_add_with_gas -8 ✅ -1.38%
Auth::get_authorized -26 ✅ -1.40%
DocsExample::get_public_immutable_constrained_public_indirect -10 ✅ -1.45%
Token::total_supply -5 ✅ -1.45%
Test::assert_public_global_vars -6 ✅ -1.48%
AvmTest::nested_call_to_add_n_times_different_addresses -12 ✅ -1.49%
AvmTest::keccak_hash -34 ✅ -1.49%
Uniswap::swap_public -239 ✅ -1.52%
Child::set_value_twice_with_nested_first -10 ✅ -1.57%
Router::public_dispatch -36 ✅ -1.57%
DocsExample::get_public_immutable_constrained_public_multiple -6 ✅ -1.59%
Child::set_value_twice_with_nested_last -10 ✅ -1.60%
Parent::pub_entry_point -10 ✅ -1.63%
StaticParent::public_call -10 ✅ -1.63%
AvmTest::u128_from_integer_overflow -13 ✅ -1.65%
StaticParent::public_get_value_from_child -10 ✅ -1.69%
TokenBlacklist::constructor -116 ✅ -1.72%
Test::consume_message_from_arbitrary_sender_public -136 ✅ -1.75%
CardGame::public_dispatch -267 ✅ -1.75%
AvmTest::return_oracle -8 ✅ -1.88%
AvmTest::revert_oracle -8 ✅ -1.89%
AvmTest::create_different_nullifier_in_nested_call -10 ✅ -1.89%
Token::constructor -83 ✅ -1.90%
AvmTest::create_same_nullifier_in_nested_call -10 ✅ -1.92%
NFT::constructor -83 ✅ -1.94%
FeeJuice::set_portal -6 ✅ -1.94%
ImportTest::pub_call_public_fn -10 ✅ -1.94%
AvmTest::nested_static_call_to_set_storage -10 ✅ -1.95%
AvmTest::nested_call_to_nothing_recovers -6 ✅ -1.95%
AvmTest::nested_static_call_to_add -12 ✅ -1.98%
AvmTest::nested_call_to_assert_same -12 ✅ -1.98%
AvmTest::nested_call_to_add -12 ✅ -1.98%
AvmTest::external_call_to_divide_by_zero -10 ✅ -2.00%
AvmTest::external_call_to_assertion_failure -10 ✅ -2.00%
AvmTest::nested_call_to_nothing -10 ✅ -2.00%
AvmTest::sha256_hash -69 ✅ -2.01%
Child::pub_inc_value_internal -6 ✅ -2.05%
Parent::public_dispatch -158 ✅ -2.07%
AvmTest::read_storage_list -6 ✅ -2.07%
StaticChild::pub_illegal_inc_value -6 ✅ -2.09%
AvmTest::n_new_public_logs -6 ✅ -2.17%
TokenBridge::_assert_token_is_same -6 ✅ -2.22%
TokenBridge::get_portal_address_public -6 ✅ -2.22%
TokenBridge::claim_public -294 ✅ -2.31%
Token::public_get_decimals -6 ✅ -2.37%
TokenBridge::exit_to_l1_public -194 ✅ -2.43%
Child::pub_inc_value -6 ✅ -2.44%
StaticChild::pub_inc_value -6 ✅ -2.44%
NFT::get_admin -6 ✅ -2.52%
NFT::public_get_name -6 ✅ -2.52%
Token::public_get_name -6 ✅ -2.52%
Token::public_get_symbol -6 ✅ -2.52%
Test::consume_mint_to_public_message -277 ✅ -2.55%
Child::pub_set_value -6 ✅ -2.55%
NFT::set_admin -6 ✅ -2.55%
StaticChild::pub_set_value -6 ✅ -2.55%
Token::set_admin -6 ✅ -2.55%
AuthWitTest::consume_public -17 ✅ -2.56%
EasyPrivateVoting::end_vote -6 ✅ -2.56%
Token::public_dispatch -819 ✅ -2.57%
DocsExample::initialize_public_immutable -6 ✅ -2.60%
NFT::public_get_symbol -6 ✅ -2.62%
TokenBridge::get_token -6 ✅ -2.62%
Token::get_admin -6 ✅ -2.62%
DocsExample::get_public_immutable_constrained_public -6 ✅ -2.73%
StaticChild::pub_get_value -6 ✅ -2.73%
AvmTest::variable_base_msm -6 ✅ -2.80%
DocsExample::update_leader -6 ✅ -2.87%
InclusionProofs::test_nullifier_inclusion_from_public -6 ✅ -2.90%
AvmInitializerTest::read_storage_immutable -6 ✅ -3.13%
AvmTest::n_new_l2_to_l1_msgs -6 ✅ -3.13%
AvmTest::n_new_note_hashes -6 ✅ -3.16%
AvmTest::n_new_nullifiers -6 ✅ -3.16%
Token::_reduce_total_supply -15 ✅ -3.30%
InclusionProofs::push_nullifier_public -6 ✅ -3.31%
AppSubscription::public_dispatch -141 ✅ -3.35%
TokenBlacklist::total_supply -12 ✅ -3.36%
AvmTest::emit_nullifier_and_check -6 ✅ -3.41%
AvmTest::assert_same -6 ✅ -3.41%
AvmTest::add_u128 -9 ✅ -3.44%
Child::pub_get_value -6 ✅ -3.45%
AvmTest::assert_nullifier_exists -6 ✅ -3.49%
AvmTest::assert_timestamp -6 ✅ -3.51%
Router::_check_timestamp -36 ✅ -3.53%
AvmTest::read_assert_storage_single -6 ✅ -3.53%
TokenBridge::public_dispatch -751 ✅ -3.56%
Router::_check_block_number -36 ✅ -3.59%
StatefulTest::public_dispatch -217 ✅ -3.67%
Test::is_time_equal -6 ✅ -3.68%
Test::dummy_public_call -6 ✅ -3.68%
TokenBlacklist::transfer_public -219 ✅ -3.94%
AvmTest::set_storage_list -6 ✅ -3.97%
AvmTest::modulo2 -6 ✅ -4.00%
AvmTest::l1_to_l2_msg_exists -6 ✅ -4.08%
AvmTest::note_hash_exists -6 ✅ -4.08%
AvmTest::nullifier_exists -6 ✅ -4.11%
AvmTest::set_read_storage_single -6 ✅ -4.11%
AvmTest::add_args_return -6 ✅ -4.17%
AvmTest::divide_by_zero -6 ✅ -4.23%
Uniswap::public_dispatch -1,114 ✅ -4.27%
AvmTest::read_storage_single -6 ✅ -4.35%
DocsExample::spend_public_authwit -6 ✅ -4.35%
AvmTest::set_opcode_u64 -6 ✅ -4.41%
AvmTest::send_l2_to_l1_msg -6 ✅ -4.44%
Test::create_l2_to_l1_message_arbitrary_recipient_public -6 ✅ -4.44%
AvmTest::set_storage_single -6 ✅ -4.48%
AvmTest::set_opcode_u32 -6 ✅ -4.55%
AvmTest::nullifier_collision -6 ✅ -4.58%
AvmTest::assert_calldata_copy -24 ✅ -4.62%
AvmTest::get_fee_per_da_gas -6 ✅ -4.69%
AvmTest::get_block_number -6 ✅ -4.69%
AvmTest::get_da_gas_left -6 ✅ -4.69%
AvmTest::get_transaction_fee -6 ✅ -4.69%
AvmTest::get_timestamp -6 ✅ -4.69%
AvmTest::get_sender -6 ✅ -4.69%
AvmTest::get_chain_id -6 ✅ -4.69%
AvmTest::get_version -6 ✅ -4.69%
AvmTest::get_l2_gas_left -6 ✅ -4.69%
AvmTest::get_fee_per_l2_gas -6 ✅ -4.69%
AvmTest::get_address -6 ✅ -4.69%
AvmTest::set_opcode_u8 -6 ✅ -4.69%
AvmTest::new_nullifier -6 ✅ -4.72%
AvmTest::new_note_hash -6 ✅ -4.72%
Test::emit_nullifier_public -6 ✅ -4.72%
Test::public_dispatch -942 ✅ -5.10%
AMM::_add_liquidity -516 ✅ -5.68%
Lending::public_dispatch -1,732 ✅ -6.25%
AvmTest::set_opcode_big_field -12 ✅ -7.23%
AvmTest::set_opcode_really_big_field -12 ✅ -7.23%
AvmTest::set_opcode_small_field -12 ✅ -8.00%
TokenBlacklist::public_dispatch -2,079 ✅ -8.13%
NFT::public_dispatch -2,389 ✅ -9.47%
Lending::get_position -683 ✅ -13.68%
AMM::public_dispatch -4,045 ✅ -15.53%
FPC::public_dispatch -1,817 ✅ -18.08%
AuthRegistry::is_consumable -403 ✅ -18.89%
AuthRegistry::_set_authorized -407 ✅ -19.11%
AuthRegistry::set_authorized -407 ✅ -19.54%
AuthRegistry::consume -730 ✅ -19.57%
AuthRegistry::public_dispatch -1,735 ✅ -20.23%
NFT::mint -1,152 ✅ -35.09%
Full diff report 👇
Program Bytecode size in bytes (+/-) %
Crowdfunding::_publish_donation_receipts 898 (+532) +145.36%
TestLog::emit_unencrypted_events 1,095 (+333) +43.70%
AvmTest::assertion_failure 215 (+52) +31.90%
TestLog::public_dispatch 2,195 (+474) +27.54%
AvmTest::returndata_copy_oracle 1,726 (+338) +24.35%
Test::emit_public 1,399 (+263) +23.15%
Lending::get_assets 432 (+43) +11.05%
AvmTest::emit_public_log 2,648 (+258) +10.79%
Crowdfunding::public_dispatch 4,412 (+331) +8.11%
Uniswap::_approve_bridge_and_exit_input_asset_to_L1 7,115 (+498) +7.53%
StaticChild::public_dispatch 2,027 (+131) +6.91%
CardGame::on_game_joined 5,583 (+338) +6.44%
AvmTest::get_args_hash 1,822 (+101) +5.87%
Parent::pub_entry_point_twice 1,001 (+46) +4.82%
Child::public_dispatch 4,753 (+211) +4.65%
Token::burn_public 4,299 (+170) +4.12%
NFT::transfer_in_public 3,491 (+133) +3.96%
Child::set_value_with_two_nested_calls 969 (+33) +3.53%
DocsExample::public_dispatch 3,753 (+117) +3.22%
AMM::_swap_exact_tokens_for_tokens 5,714 (+164) +2.95%
Benchmarking::public_dispatch 3,444 (+97) +2.90%
EasyPrivateVoting::public_dispatch 4,724 (+132) +2.87%
AMM::_swap_tokens_for_exact_tokens 6,429 (+172) +2.75%
Lending::repay_public 2,711 (+72) +2.73%
Lending::deposit_public 2,841 (+72) +2.60%
AvmTest::read_storage_map 1,541 (+39) +2.60%
AuthRegistry::is_reject_all 1,582 (+39) +2.53%
NFT::is_minter 1,636 (+39) +2.44%
AuthRegistry::set_reject_all 1,533 (+35) +2.34%
StatefulTest::get_public_value 1,567 (+34) +2.22%
NFT::_finish_transfer_to_public 1,617 (+35) +2.21%
NFT::set_minter 1,635 (+35) +2.19%
Token::is_minter 1,631 (+34) +2.13%
PriceFeed::set_price 1,559 (+32) +2.10%
AvmTest::bulk_testing 22,595 (+461) +2.08%
StatefulTest::increment_public_value_no_init_check 1,528 (+30) +2.00%
InclusionProofs::public_dispatch 3,825 (+75) +2.00%
NFT::owner_of 1,788 (+35) +2.00%
TokenBlacklist::balance_of_public 1,734 (+33) +1.94%
StatefulTest::increment_public_value 1,577 (+30) +1.94%
Benchmarking::broadcast 1,601 (+30) +1.91%
Token::set_minter 1,630 (+30) +1.88%
Lending::update_accumulator 5,538 (+98) +1.80%
FeeJuice::check_balance 1,965 (+32) +1.66%
ImportTest::public_dispatch 1,113 (+16) +1.46%
FeeJuice::balance_of_public 1,676 (+24) +1.45%
PriceFeed::get_price 1,676 (+24) +1.45%
Token::balance_of_public 1,730 (+24) +1.41%
Lending::_repay 5,378 (+73) +1.38%
AMM::_remove_liquidity 7,202 (+90) +1.27%
Token::mint_to_public 2,263 (+21) +0.94%
TokenBlacklist::_increase_public_balance 2,265 (+20) +0.89%
InclusionProofs::constructor 2,417 (+19) +0.79%
AMM::constructor 2,713 (+21) +0.78%
TokenBlacklist::shield 5,642 (+40) +0.71%
AvmTest::n_storage_writes 1,569 (+9) +0.58%
Token::transfer_in_public 4,374 (+23) +0.53%
FPC::pull_funds 2,768 (+14) +0.51%
TokenBlacklist::_reduce_total_supply 538 (+2) +0.37%
FeeJuice::public_dispatch 4,577 (+15) +0.33%
Token::_increase_public_balance 2,166 (+3) +0.14%
CardGame::on_card_played 6,422 (+7) +0.11%
Spam::public_dispatch 2,974 (-1) -0.03%
Lending::init 2,728 (-1) -0.04%
Spam::public_spam 2,193 (-1) -0.05%
Lending::_withdraw 8,420 (-4) -0.05%
Lending::_borrow 8,254 (-4) -0.05%
TokenBlacklist::mint_public 3,529 (-3) -0.08%
AuthWitTest::public_dispatch 1,501 (-4) -0.27%
AvmTest::external_call_to_divide_by_zero_recovers 2,819 (-9) -0.32%
Parent::public_nested_static_call 3,501 (-13) -0.37%
PriceFeed::public_dispatch 2,688 (-10) -0.37%
Token::_finalize_transfer_to_private_unsafe 5,155 (-23) -0.44%
Token::finalize_transfer_to_private 5,108 (-23) -0.45%
AvmTest::debug_logging 1,318 (-6) -0.45%
AvmInitializerTest::public_dispatch 2,632 (-12) -0.45%
StaticParent::public_nested_static_call 2,114 (-10) -0.47%
Lending::withdraw_public 2,055 (-10) -0.48%
Lending::borrow_public 2,055 (-10) -0.48%
EasyPrivateVoting::add_to_tally_public 1,840 (-9) -0.49%
AvmTest::add_storage_map 1,688 (-9) -0.53%
AvmTest::set_storage_map 1,586 (-9) -0.56%
StaticParent::public_dispatch 5,606 (-32) -0.57%
Benchmarking::increment_balance 2,189 (-13) -0.59%
Claim::public_dispatch 3,531 (-21) -0.59%
AvmTest::poseidon2_hash 1,512 (-9) -0.59%
FPC::pay_refund 2,662 (-16) -0.60%
AvmInitializerTest::constructor 1,874 (-12) -0.64%
TokenBlacklist::update_roles 6,375 (-42) -0.65%
Lending::get_asset 2,227 (-15) -0.67%
TokenBridge::constructor 2,670 (-18) -0.67%
FPC::constructor 2,631 (-18) -0.68%
AvmTest::u128_addition_overflow 1,293 (-9) -0.69%
Claim::constructor 2,766 (-21) -0.75%
Auth::constructor 2,527 (-20) -0.79%
EasyPrivateVoting::constructor 2,523 (-20) -0.79%
NFT::_finalize_transfer_to_private_unsafe 4,616 (-37) -0.80%
AvmTest::pedersen_hash_with_index 2,869 (-23) -0.80%
AvmTest::pedersen_hash 2,869 (-23) -0.80%
Uniswap::constructor 2,486 (-20) -0.80%
Auth::public_dispatch 9,186 (-74) -0.80%
NFT::finalize_transfer_to_private 4,569 (-37) -0.80%
TokenBlacklist::mint_private 3,682 (-30) -0.81%
CardGame::start_game 6,990 (-58) -0.82%
StatefulTest::public_constructor 2,887 (-24) -0.82%
TokenBlacklist::burn_public 4,914 (-41) -0.83%
Crowdfunding::init 2,746 (-23) -0.83%
AvmTest::elliptic_curve_add_and_double 713 (-6) -0.83%
Parent::public_static_call 1,164 (-10) -0.85%
StaticParent::public_static_call 1,164 (-10) -0.85%
Lending::_deposit 2,495 (-22) -0.87%
FeeJuice::_increase_public_balance 1,907 (-18) -0.94%
CardGame::on_cards_claimed 7,681 (-74) -0.95%
NFT::_store_payload_in_transient_storage_unsafe 1,130 (-11) -0.96%
Token::_store_payload_in_transient_storage_unsafe 1,130 (-11) -0.96%
Token::_finalize_mint_to_private_unsafe 4,803 (-49) -1.01%
Auth::get_authorized_delay 1,960 (-20) -1.01%
Token::finalize_mint_to_private 4,756 (-49) -1.02%
AvmTest::elliptic_curve_add 580 (-6) -1.02%
Test::create_l2_to_l1_message_public 1,976 (-23) -1.15%
AvmTest::public_dispatch 62,282 (-748) -1.19%
AvmTest::pedersen_commit 1,162 (-14) -1.19%
AvmTest::keccak_f1600 498 (-6) -1.19%
TokenBlacklist::get_roles 2,671 (-34) -1.26%
AppSubscription::constructor 3,023 (-39) -1.27%
AvmTest::test_get_contract_instance 458 (-6) -1.29%
AvmTest::test_get_contract_instance_matches 453 (-6) -1.31%
Auth::get_scheduled_authorized 1,731 (-23) -1.31%
Auth::set_authorized 4,791 (-64) -1.32%
Uniswap::_assert_token_is_same 743 (-10) -1.33%
Auth::set_authorized_delay 4,887 (-66) -1.33%
AvmTest::to_radix_le 433 (-6) -1.37%
AvmTest::nested_call_to_add_with_gas 570 (-8) -1.38%
Auth::get_authorized 1,826 (-26) -1.40%
DocsExample::get_public_immutable_constrained_public_indirect 682 (-10) -1.45%
Token::total_supply 341 (-5) -1.45%
Test::assert_public_global_vars 400 (-6) -1.48%
AvmTest::nested_call_to_add_n_times_different_addresses 793 (-12) -1.49%
AvmTest::keccak_hash 2,241 (-34) -1.49%
Uniswap::swap_public 15,447 (-239) -1.52%
Child::set_value_twice_with_nested_first 628 (-10) -1.57%
Router::public_dispatch 2,254 (-36) -1.57%
DocsExample::get_public_immutable_constrained_public_multiple 371 (-6) -1.59%
Child::set_value_twice_with_nested_last 615 (-10) -1.60%
Parent::pub_entry_point 604 (-10) -1.63%
StaticParent::public_call 604 (-10) -1.63%
AvmTest::u128_from_integer_overflow 777 (-13) -1.65%
StaticParent::public_get_value_from_child 581 (-10) -1.69%
TokenBlacklist::constructor 6,610 (-116) -1.72%
Test::consume_message_from_arbitrary_sender_public 7,640 (-136) -1.75%
CardGame::public_dispatch 14,967 (-267) -1.75%
AvmTest::return_oracle 418 (-8) -1.88%
AvmTest::revert_oracle 416 (-8) -1.89%
AvmTest::create_different_nullifier_in_nested_call 520 (-10) -1.89%
Token::constructor 4,281 (-83) -1.90%
AvmTest::create_same_nullifier_in_nested_call 510 (-10) -1.92%
NFT::constructor 4,206 (-83) -1.94%
FeeJuice::set_portal 303 (-6) -1.94%
ImportTest::pub_call_public_fn 505 (-10) -1.94%
AvmTest::nested_static_call_to_set_storage 504 (-10) -1.95%
AvmTest::nested_call_to_nothing_recovers 302 (-6) -1.95%
AvmTest::nested_static_call_to_add 595 (-12) -1.98%
AvmTest::nested_call_to_assert_same 595 (-12) -1.98%
AvmTest::nested_call_to_add 595 (-12) -1.98%
AvmTest::external_call_to_divide_by_zero 490 (-10) -2.00%
AvmTest::external_call_to_assertion_failure 490 (-10) -2.00%
AvmTest::nested_call_to_nothing 490 (-10) -2.00%
AvmTest::sha256_hash 3,360 (-69) -2.01%
Child::pub_inc_value_internal 286 (-6) -2.05%
Parent::public_dispatch 7,479 (-158) -2.07%
AvmTest::read_storage_list 284 (-6) -2.07%
StaticChild::pub_illegal_inc_value 281 (-6) -2.09%
AvmTest::n_new_public_logs 270 (-6) -2.17%
TokenBridge::_assert_token_is_same 264 (-6) -2.22%
TokenBridge::get_portal_address_public 264 (-6) -2.22%
TokenBridge::claim_public 12,417 (-294) -2.31%
Token::public_get_decimals 247 (-6) -2.37%
TokenBridge::exit_to_l1_public 7,792 (-194) -2.43%
Child::pub_inc_value 240 (-6) -2.44%
StaticChild::pub_inc_value 240 (-6) -2.44%
NFT::get_admin 232 (-6) -2.52%
NFT::public_get_name 232 (-6) -2.52%
Token::public_get_name 232 (-6) -2.52%
Token::public_get_symbol 232 (-6) -2.52%
Test::consume_mint_to_public_message 10,575 (-277) -2.55%
Child::pub_set_value 229 (-6) -2.55%
NFT::set_admin 229 (-6) -2.55%
StaticChild::pub_set_value 229 (-6) -2.55%
Token::set_admin 229 (-6) -2.55%
AuthWitTest::consume_public 648 (-17) -2.56%
EasyPrivateVoting::end_vote 228 (-6) -2.56%
Token::public_dispatch 31,020 (-819) -2.57%
DocsExample::initialize_public_immutable 225 (-6) -2.60%
NFT::public_get_symbol 223 (-6) -2.62%
TokenBridge::get_token 223 (-6) -2.62%
Token::get_admin 223 (-6) -2.62%
DocsExample::get_public_immutable_constrained_public 214 (-6) -2.73%
StaticChild::pub_get_value 214 (-6) -2.73%
AvmTest::variable_base_msm 208 (-6) -2.80%
DocsExample::update_leader 203 (-6) -2.87%
InclusionProofs::test_nullifier_inclusion_from_public 201 (-6) -2.90%
AvmInitializerTest::read_storage_immutable 186 (-6) -3.13%
AvmTest::n_new_l2_to_l1_msgs 186 (-6) -3.13%
AvmTest::n_new_note_hashes 184 (-6) -3.16%
AvmTest::n_new_nullifiers 184 (-6) -3.16%
Token::_reduce_total_supply 439 (-15) -3.30%
InclusionProofs::push_nullifier_public 175 (-6) -3.31%
AppSubscription::public_dispatch 4,065 (-141) -3.35%
TokenBlacklist::total_supply 345 (-12) -3.36%
AvmTest::emit_nullifier_and_check 170 (-6) -3.41%
AvmTest::assert_same 170 (-6) -3.41%
AvmTest::add_u128 253 (-9) -3.44%
Child::pub_get_value 168 (-6) -3.45%
AvmTest::assert_nullifier_exists 166 (-6) -3.49%
AvmTest::assert_timestamp 165 (-6) -3.51%
Router::_check_timestamp 985 (-36) -3.53%
AvmTest::read_assert_storage_single 164 (-6) -3.53%
TokenBridge::public_dispatch 20,339 (-751) -3.56%
Router::_check_block_number 968 (-36) -3.59%
StatefulTest::public_dispatch 5,692 (-217) -3.67%
Test::is_time_equal 157 (-6) -3.68%
Test::dummy_public_call 157 (-6) -3.68%
TokenBlacklist::transfer_public 5,346 (-219) -3.94%
AvmTest::set_storage_list 145 (-6) -3.97%
AvmTest::modulo2 144 (-6) -4.00%
AvmTest::l1_to_l2_msg_exists 141 (-6) -4.08%
AvmTest::note_hash_exists 141 (-6) -4.08%
AvmTest::nullifier_exists 140 (-6) -4.11%
AvmTest::set_read_storage_single 140 (-6) -4.11%
AvmTest::add_args_return 138 (-6) -4.17%
AvmTest::divide_by_zero 136 (-6) -4.23%
Uniswap::public_dispatch 24,954 (-1,114) -4.27%
AvmTest::read_storage_single 132 (-6) -4.35%
DocsExample::spend_public_authwit 132 (-6) -4.35%
AvmTest::set_opcode_u64 130 (-6) -4.41%
AvmTest::send_l2_to_l1_msg 129 (-6) -4.44%
Test::create_l2_to_l1_message_arbitrary_recipient_public 129 (-6) -4.44%
AvmTest::set_storage_single 128 (-6) -4.48%
AvmTest::set_opcode_u32 126 (-6) -4.55%
AvmTest::nullifier_collision 125 (-6) -4.58%
AvmTest::assert_calldata_copy 495 (-24) -4.62%
AvmTest::get_fee_per_da_gas 122 (-6) -4.69%
AvmTest::get_block_number 122 (-6) -4.69%
AvmTest::get_da_gas_left 122 (-6) -4.69%
AvmTest::get_transaction_fee 122 (-6) -4.69%
AvmTest::get_timestamp 122 (-6) -4.69%
AvmTest::get_sender 122 (-6) -4.69%
AvmTest::get_chain_id 122 (-6) -4.69%
AvmTest::get_version 122 (-6) -4.69%
AvmTest::get_l2_gas_left 122 (-6) -4.69%
AvmTest::get_fee_per_l2_gas 122 (-6) -4.69%
AvmTest::get_address 122 (-6) -4.69%
AvmTest::set_opcode_u8 122 (-6) -4.69%
AvmTest::new_nullifier 121 (-6) -4.72%
AvmTest::new_note_hash 121 (-6) -4.72%
Test::emit_nullifier_public 121 (-6) -4.72%
Test::public_dispatch 17,522 (-942) -5.10%
AMM::_add_liquidity 8,576 (-516) -5.68%
Lending::public_dispatch 25,988 (-1,732) -6.25%
AvmTest::set_opcode_big_field 154 (-12) -7.23%
AvmTest::set_opcode_really_big_field 154 (-12) -7.23%
AvmTest::set_opcode_small_field 138 (-12) -8.00%
TokenBlacklist::public_dispatch 23,507 (-2,079) -8.13%
NFT::public_dispatch 22,850 (-2,389) -9.47%
Lending::get_position 4,310 (-683) -13.68%
AMM::public_dispatch 22,000 (-4,045) -15.53%
FPC::public_dispatch 8,231 (-1,817) -18.08%
AuthRegistry::is_consumable 1,730 (-403) -18.89%
AuthRegistry::_set_authorized 1,723 (-407) -19.11%
AuthRegistry::set_authorized 1,676 (-407) -19.54%
AuthRegistry::consume 3,000 (-730) -19.57%
AuthRegistry::public_dispatch 6,843 (-1,735) -20.23%
NFT::mint 2,131 (-1,152) -35.09%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025 •
edited
Loading

Changes to circuit sizes

Generated at commit: 6534c073af9992e57a0ae591d6d876c1c2dc7ee3, compared to commit: f4e2953632ad4fdcf0a6cf00eda4b16b4b3db0f2

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_inner +1 ❌ +0.00% +1 ❌ +0.00%
Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_inner 28,368 (+1) +0.00% 72,234 (+1) +0.00%

just-mitch
just-mitch commented Jan 31, 2025
View reviewed changes
spartan/metrics/values/prod.yaml
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can also set

tempo:
  enabled: false

in this file

just-mitch
just-mitch commented Jan 31, 2025
View reviewed changes
spartan/metrics/values/prod.yaml
statefulSet:
enabled: true

loki:
enabled: false
loki:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realistically, with loki.enabled: false we ought to be able to just delete the nested loki.loki key

just-mitch
just-mitch commented Jan 31, 2025
View reviewed changes
spartan/metrics/values/prod.yaml
@@ -1,4 +1,7 @@
opentelemetry-collector:
mode: deployment
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need to set these anymore since they're pulled from the main values.

@just-mitch just-mitch added the network-all Run this CI job. label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@PhilWindle PhilWindle

Labels
network-all Run this CI job.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@just-mitch @PhilWindle