Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ensuring sandbox/aztec.js errors are clear #1185

Merged
merged 11 commits into from
Jul 26, 2023
Merged

feat: ensuring sandbox/aztec.js errors are clear #1185

merged 11 commits into from
Jul 26, 2023

Conversation

benesjan
Copy link
Contributor

@benesjan benesjan commented Jul 25, 2023 •
edited
Loading

Description

Partially addresses #1115

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@netlify
Copy link

netlify bot commented Jul 25, 2023 •
edited
Loading

✅ Deploy Preview for preeminent-bienenstitch-606ad0 canceled.

Name Link
🔨 Latest commit d94a0a5
🔍 Latest deploy log https://app.netlify.com/sites/preeminent-bienenstitch-606ad0/deploys/64c13d8931add0000882a81c

@benesjan benesjan mentioned this pull request Jul 25, 2023
Closed
@benesjan benesjan force-pushed the janb/clear-errors branch 2 times, most recently from baeb7b7 to 3dad22f Compare July 26, 2023 09:09
@benesjan benesjan marked this pull request as draft July 26, 2023 14:11
@benesjan benesjan marked this pull request as ready for review July 26, 2023 14:52
@benesjan benesjan force-pushed the janb/clear-errors branch from b57310f to df98d97 Compare July 26, 2023 14:52
@benesjan @spalladino
Apply suggestions from code review
c391766 
Co-authored-by: Santiago Palladino <[email protected]>
dbanks12
dbanks12 approved these changes Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@dbanks12 dbanks12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@benesjan benesjan enabled auto-merge (squash) July 26, 2023 15:37
@benesjan benesjan merged commit 340cb50 into master Jul 26, 2023
@benesjan benesjan deleted the janb/clear-errors branch July 26, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalladino spalladino spalladino approved these changes

@dbanks12 dbanks12 dbanks12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benesjan @spalladino @dbanks12