Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(contracts): Clean up noir artifacts #1192

Merged
merged 4 commits into from
Jul 26, 2023
Merged

chore(contracts): Clean up noir artifacts #1192

merged 4 commits into from
Jul 26, 2023

Conversation

spalladino
Copy link
Collaborator

  • Remove build artifacts from Noir contracts that no longer exist
  • Update reference in account implementation in aztecjs to reference updated contract
  • Have the build script warn when there are stale artifacts

@spalladino spalladino requested a review from LHerskind July 25, 2023 20:43
@netlify
Copy link

netlify bot commented Jul 25, 2023 •
edited
Loading

✅ Deploy Preview for preeminent-bienenstitch-606ad0 canceled.

Name Link
🔨 Latest commit 35d607b
🔍 Latest deploy log https://app.netlify.com/sites/preeminent-bienenstitch-606ad0/deploys/64c033e168d01d00084d3c0d

@spalladino
Copy link
Collaborator Author

Hopefully this will no longer be needed when we stop committing noir build artifacts to source control

@spalladino spalladino merged commit 661d6d8 into master Jul 26, 2023
@spalladino spalladino deleted the palla/clean-up-noir-artifacts branch July 26, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludamad ludamad ludamad approved these changes

@LHerskind LHerskind Awaiting requested review from LHerskind

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spalladino @ludamad