feat: parallelize noir contracts compilation #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for preeminent-bienenstitch-606ad0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Maddiaa0
force-pushed
the
md/noir-compile-brr
branch
from
275ee3f to
8609ac2
Compare
codygunton
added a commit
that referenced
this pull request
Jan 23, 2024
* wip * Added more base case tests. * Pw/gas limit accounting (#1116) * Initial work * WIP * Account for gas usage when limiting txs per rollup * Minor logging change * Correctly pass through the gas limit * Fixed calculation for max txs per rollup * add cody'ssimple debugging tests in standard_composer.test * making use of large_quotient again to begin debugging * step 1 is passing: quotient pieces with no blinding * Step 2 passing (lnearized): using quotient pieces w/ non-trivial blinding, still using quotient_large for ifft * serial split fft works. * parallel fft on split works. * coset fft, ifft works. * unrolled case works. Co-authored-by: ledwards2225 <[email protected]> * msm sizes updated. * some cleanup and debugging code removal, all tests still passing * removing quotient_mid altogether - one more fctn can possibly be removed or simplified * wip quotient split. * quotients match: old case and split case! * standard plonk fix. * Remove quotient_large and correctly compute t_eval. * All but one tests work. * Turbo test fix. * fixes and minor opt. * a couple of comment fixes * more comment fixes and removal of debugging code * One acc test fix: srs size. * uint32_t -> sizet_t * Minor fix in split-evaluate. * Fix acc and other failing tests by correct initialisation of (n+1)th coefficient. * js test fix. * Correct reset proving key fn. * minor reorder. * Ariel's suggestions. Co-authored-by: Ariel <[email protected]> * bb.js: account crs fix. * bb.js: crs size fix. * bb.js fix: MSM size adjusted as n or n+1 according to the polynomial. Co-authored-by: Leila Wang <[email protected]> * Remove mid_domain and use_mid_for_selectorfft * Remove comments. * Minor edits. * Arijits suggestions. * Added a comment in pkey. * comment correction. Co-authored-by: codygunton <[email protected]> Co-authored-by: PhilWindle <[email protected]> Co-authored-by: ledwards2225 <[email protected]> Co-authored-by: ledwards2225 <[email protected]> Co-authored-by: Ariel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist: