feat: node upgrade infra #12127

just-mitch · 2025-02-20T01:50:18Z

Add utilities to make upgrades easy. Confirm that upgrades work in a spartan environment by:

Doing a network deployment
Deploying a new rollup and a payload to make it the new canonical
Proposing that via the sequencers
Executing that GovernanceProposal
Going through the standard governance vote, then executing the payload
Restarting all the pods, and making sure we're building/proving on the new rollup.

Fix #9638
Fix #12071
Fix #12145

just-mitch · 2025-02-20T01:50:34Z

e2e upgrade test #12155
feat: node upgrade infra #12127 👈 (View in Graphite)
feat: fetch addresses from registry #12000
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

just-mitch · 2025-02-26T02:47:36Z

l1-contracts/src/governance/Governance.sol

-      votingDuration: Timestamp.wrap(3600),
-      executionDelay: Timestamp.wrap(3600),
-      gracePeriod: Timestamp.wrap(3600),
+      votingDelay: Timestamp.wrap(60),


Is there an issue for picking real values for these?

Was 60 picked to make the test work? I would prefer they default high but we adjust the slot in a test to a lower value

As discussed offline, the 60 was picked just to make the test fast, and acknowledging that for the first few upgrades on testnet, aztec labs likely be using proposeWithLock and voting, so shorter times are preferable.

Ideally these are configurable in a constructor, similar to the governanceproposer.

just-mitch · 2025-02-26T02:49:37Z

yarn-project/ethereum/src/contracts/governance.ts

+    return walletGovernance.read.powerAt([this.walletClient!.account.address, now.timestamp]);
+  }
+
+  public async vote({


This can obviously be DRYed with some kind of generic function.

Maddiaa0 · 2025-02-26T11:38:26Z

spartan/aztec-network/files/config/deploy-l1-contracts.sh

@@ -38,32 +54,12 @@ done || {
 echo "$output"

 # Extract contract addresses using grep and regex
-rollup_address=$(echo "$output" | grep -oP 'Rollup Address: \K0x[a-fA-F0-9]{40}')
 registry_address=$(echo "$output" | grep -oP 'Registry Address: \K0x[a-fA-F0-9]{40}')


Maddiaa0 · 2025-02-26T12:03:01Z

yarn-project/aztec/src/sandbox.ts

@@ -258,7 +258,14 @@ export async function createAztecNode(
  deps: { telemetry?: TelemetryClient; blobSinkClient?: BlobSinkClientInterface } = {},
  options: { prefilledPublicData?: PublicDataTreeLeaf[] } = {},
 ) {
-  const aztecNodeConfig: AztecNodeConfig = { ...getConfigEnvVars(), ...config };
+  // TODO(#12272): will clean this up. This is criminal.


Throwback to aztec connect's configurator

Maddiaa0 · 2025-02-26T12:04:41Z

yarn-project/cli/src/cmds/l1/get_l1_addresses.ts

+
+import { createPublicClient, http } from 'viem';
+
+export async function getL1Addresses(


Maddiaa0 · 2025-02-26T12:05:17Z

yarn-project/cli/src/cmds/l1/governance_utils.ts

@@ -0,0 +1,187 @@
+import {


Maddiaa0

awesome awesome awesome awesome awesome awesome

charlielye

I approve the change to the bootstrap.sh

just-mitch mentioned this pull request Feb 20, 2025

feat: fetch addresses from registry #12000

Merged

This was linked to issues Feb 20, 2025

test: upgrade cluster via voting #9638

Closed

feat(cli): deploy new rollup version #12071

Closed

just-mitch mentioned this pull request Feb 20, 2025

e2e upgrade test #12155

Draft

just-mitch force-pushed the 02-19-kind_upgrade_test branch 3 times, most recently from 46bfe8d to 4985107 Compare February 24, 2025 01:01

just-mitch force-pushed the 02-13-feat_fetch_addresses_from_registry branch from c64b04d to c9994ec Compare February 24, 2025 15:22

just-mitch force-pushed the 02-19-kind_upgrade_test branch from 4985107 to bd889f9 Compare February 24, 2025 15:22

just-mitch changed the title ~~kind upgrade test~~ feat: node upgrade infra Feb 25, 2025

just-mitch marked this pull request as ready for review February 25, 2025 00:36

just-mitch requested a review from charlielye as a code owner February 25, 2025 00:36

just-mitch added the ci-full Run all master checks. label Feb 25, 2025

just-mitch force-pushed the 02-13-feat_fetch_addresses_from_registry branch from c9994ec to ab4338d Compare February 25, 2025 00:40

just-mitch linked an issue Feb 25, 2025 that may be closed by this pull request

cli voting #12145

Closed

just-mitch force-pushed the 02-13-feat_fetch_addresses_from_registry branch from ab4338d to 7936b84 Compare February 25, 2025 13:36

just-mitch force-pushed the 02-19-kind_upgrade_test branch 2 times, most recently from 9624c31 to 7af3690 Compare February 25, 2025 14:26

just-mitch force-pushed the 02-13-feat_fetch_addresses_from_registry branch from 7936b84 to 5e290d9 Compare February 25, 2025 16:34

just-mitch force-pushed the 02-19-kind_upgrade_test branch from 7af3690 to a885fca Compare February 25, 2025 16:34

just-mitch force-pushed the 02-13-feat_fetch_addresses_from_registry branch 4 times, most recently from 379759b to 35ab869 Compare February 25, 2025 20:38

just-mitch force-pushed the 02-19-kind_upgrade_test branch 3 times, most recently from e360e3b to b7279c9 Compare February 25, 2025 23:33

just-mitch force-pushed the 02-13-feat_fetch_addresses_from_registry branch from 35ab869 to 8bddbcb Compare February 26, 2025 02:08

just-mitch force-pushed the 02-19-kind_upgrade_test branch from b7279c9 to 4dd08e7 Compare February 26, 2025 02:08

just-mitch commented Feb 26, 2025

View reviewed changes

just-mitch force-pushed the 02-19-kind_upgrade_test branch from 4dd08e7 to 0131a55 Compare February 26, 2025 02:50

just-mitch force-pushed the 02-13-feat_fetch_addresses_from_registry branch from 8bddbcb to c1a2bd1 Compare February 26, 2025 02:59

just-mitch force-pushed the 02-19-kind_upgrade_test branch from 0131a55 to 20a306d Compare February 26, 2025 02:59

Maddiaa0 reviewed Feb 26, 2025

View reviewed changes

yarn-project/cli/src/cmds/l1/governance_utils.ts

@@ -0,0 +1,187 @@

import {

Copy link

Member

Maddiaa0 Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

Maddiaa0 approved these changes Feb 26, 2025

View reviewed changes

just-mitch force-pushed the 02-13-feat_fetch_addresses_from_registry branch from c1a2bd1 to cd46471 Compare February 26, 2025 16:47

just-mitch changed the base branch from 02-13-feat_fetch_addresses_from_registry to graphite-base/12127 February 26, 2025 17:34

just-mitch force-pushed the 02-19-kind_upgrade_test branch from 20a306d to 9d24400 Compare February 26, 2025 17:39

just-mitch requested review from fcarreiro and dbanks12 as code owners February 26, 2025 17:39

just-mitch changed the base branch from graphite-base/12127 to master February 26, 2025 17:39

charlielye approved these changes Feb 26, 2025

View reviewed changes

just-mitch force-pushed the 02-19-kind_upgrade_test branch from 9d24400 to b3628eb Compare February 26, 2025 20:01

feat: fetch addresses from registry

acabcde

just-mitch force-pushed the 02-19-kind_upgrade_test branch 4 times, most recently from e811637 to f9ff4ab Compare February 27, 2025 01:01

just-mitch removed the ci-full Run all master checks. label Feb 27, 2025

just-mitch force-pushed the 02-19-kind_upgrade_test branch from f9ff4ab to bb2043e Compare February 27, 2025 01:51

kind upgrade test

04afa69

just-mitch force-pushed the 02-19-kind_upgrade_test branch from bb2043e to 04afa69 Compare February 27, 2025 12:19

just-mitch added the ci-full Run all master checks. label Feb 27, 2025 — with Graphite App

just-mitch merged commit cdf29d8 into master Feb 27, 2025
17 of 19 checks passed

just-mitch deleted the 02-19-kind_upgrade_test branch February 27, 2025 12:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: node upgrade infra #12127

feat: node upgrade infra #12127

just-mitch commented Feb 20, 2025 •

edited

Loading

just-mitch commented Feb 20, 2025 •

edited

Loading

just-mitch Feb 26, 2025

Maddiaa0 Feb 26, 2025

just-mitch Feb 26, 2025

just-mitch Feb 26, 2025

Maddiaa0 Feb 26, 2025

Maddiaa0 Feb 26, 2025

just-mitch Feb 26, 2025

Maddiaa0 Feb 26, 2025

Maddiaa0 Feb 26, 2025

Maddiaa0 left a comment

charlielye left a comment


		import { createPublicClient, http } from 'viem';

		export async function getL1Addresses(

feat: node upgrade infra #12127

feat: node upgrade infra #12127

Conversation

just-mitch commented Feb 20, 2025 • edited Loading

just-mitch commented Feb 20, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Maddiaa0 left a comment

Choose a reason for hiding this comment

charlielye left a comment

Choose a reason for hiding this comment

just-mitch commented Feb 20, 2025 •

edited

Loading

just-mitch commented Feb 20, 2025 •

edited

Loading