feat: Slack message to ci channel tagging owners on flakes. #12284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
charlielye
commented
Feb 26, 2025
•
charlielye
commented
- .test_skip_patterns is now .test_patterns.yml and assigns owners to tests.
- If in CI and a matching test fails, it doesnt fail the build but slacks the log to the owner.
- Some additional denoise header metadata.
- We still "fail fast" when doing a test run locally.
ludamad
reviewed
Feb 26, 2025
| @@ -133,7 +133,7 @@ function test_cmds { | |||
| # This is a test as it runs over our test programs (format is usually considered a build step). | |||
| echo "$test_hash noir/bootstrap.sh format --check" | |||
| # We need to include these as they will go out of date otherwise and externals use these examples. | |||
| local example_test_hash=$(hash_str $test_hash-$(../barretenberg/cpp/bootstrap.sh hash)) | |||
| local example_test_hash=$(hash_str $test_hash-$(../../barretenberg/cpp/bootstrap.sh hash)) | |||
There was a problem hiding this comment.
Why did this need to change?
There was a problem hiding this comment.
It was actually silently failing i think. we cd into noir-repo.
ludamad
reviewed
Feb 26, 2025
spartan/bootstrap.sh
Outdated
| @@ -49,7 +49,7 @@ function gke { | |||
| } | |||
|
|
|||
| function test_cmds { | |||
| echo "$hash ./spartan/bootstrap.sh test-local" | |||
| # echo "$hash ./spartan/bootstrap.sh test-local" | |||
There was a problem hiding this comment.
This is skipped, still needs to be commented out?
There was a problem hiding this comment.
You said you were read to let it die, but wasn't sure. We want to keep it as a "always skip no alert"?
There was a problem hiding this comment.
I was ready to have it skipped to get in, still hold out for fixing it
ludamad
approved these changes
Feb 26, 2025
ludamad
reviewed
Feb 26, 2025
| # Send slack message to owners. | ||
| slack_uids="" | ||
| for uid in $owners; do | ||
| slack_uids+="<@$uid> " |
There was a problem hiding this comment.
Suggested change
| slack_uids+="<@$uid> " | |
| slack_uids+=" <@$uid>" |
for Palla's OCD to not do "@charlie : foo"
There was a problem hiding this comment.
Using ${slack_uids% } in L97 would also do the trick by removing trailing whitespace:
$ FOO='bar baz baq '
$ echo "${FOO% }: Test flaked"
bar baz baq: Test flaked
spalladino
reviewed
Feb 26, 2025
| @@ -94,7 +94,7 @@ function flake { | |||
| read -r -d '' data <<EOF | |||
| { | |||
| "channel": "#aztec3-ci", | |||
| "text": "${slack_uids}: Test flaked \`$test_cmd\` http://ci.aztec-labs.com/$log_key" | |||
| "text": "${slack_uids% }: Test flaked \`$test_cmd\` http://ci.aztec-labs.com/$log_key" | |||
TomAFrench
added a commit
that referenced
this pull request
Feb 26, 2025
* master: (31 commits) feat: Slack message to ci channel tagging owners on flakes. (#12284) fix: slack notify was broken by quoted commit titles revert: "chore: Fix and reenable fees-settings test (#12302)" fix: run arm64 on master (#12307) yolo fix chore: Fix and reenable fees-settings test (#12302) feat!: rename compute_nullifier_without_context (#12308) chore: Lazy loading artifacts everywhere (#12285) chore: Reenable dapp subscription test (#12304) chore: Run prover test with fake proofs when requested (#12305) chore: Do not set CI_FULL outside CI (#12300) chore: new mnemonic deployments on sepolia (#12076) chore!: enable multiple L1 nodes to be used (#11945) chore: remove no longer supported extension from vscode/extension.json (#12303) fix(e2e): p2p_reqresp (#12297) feat: Sync from noir (#12298) chore: enabling `e2e_contract_updates` in CI + nuking irrelevant test (#12293) feat: prepend based merge (#12093) feat: fetch addresses from registry (#12000) feat: live logs (#12271) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.