Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(noir): remove oracle hacks in light of stepwise ACIR execution #1243

Merged
merged 5 commits into from
Jul 27, 2023
Merged

chore(noir): remove oracle hacks in light of stepwise ACIR execution #1243

merged 5 commits into from
Jul 27, 2023

Conversation

dbanks12
Copy link
Collaborator

@dbanks12 dbanks12 commented Jul 27, 2023 •
edited
Loading

Description

Closes #1098

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@netlify
Copy link

netlify bot commented Jul 27, 2023 •
edited
Loading

✅ Deploy Preview for preeminent-bienenstitch-606ad0 canceled.

Name Link
🔨 Latest commit 55456e6
🔍 Latest deploy log https://app.netlify.com/sites/preeminent-bienenstitch-606ad0/deploys/64c291aa6690710008b77a75

@dbanks12 dbanks12 requested a review from ludamad July 27, 2023 14:51
@dbanks12 dbanks12 requested a review from jeanmon July 27, 2023 16:01
jeanmon
jeanmon approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@jeanmon jeanmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good cleaning task. We did not have any hack in TS code?

@dbanks12 dbanks12 merged commit b2f175a into master Jul 27, 2023
@dbanks12 dbanks12 deleted the db/1098-remove-oracle-order-hacks branch July 27, 2023 16:16
@dbanks12
Copy link
Collaborator Author

Good cleaning task. We did not have any hack in TS code?

Nope, not that i remember

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanmon jeanmon jeanmon approved these changes

@ludamad ludamad Awaiting requested review from ludamad

Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove hack to force oracle-ordering in Noir / ACVM
2 participants
@dbanks12 @jeanmon