Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Goblin translator prototype #1249

Merged
merged 1 commit into from
Jul 27, 2023
Merged

feat: Goblin translator prototype #1249

merged 1 commit into from
Jul 27, 2023

Conversation

Rumata888
Copy link
Contributor

Description

Added a prototype of goblin translator with accumulation gate.

Automatic formatting when committing caused changes to several files, too

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@netlify
Copy link

netlify bot commented Jul 27, 2023 •
edited
Loading

✅ Deploy Preview for preeminent-bienenstitch-606ad0 ready!

Name Link
🔨 Latest commit 9bd0559
🔍 Latest deploy log https://app.netlify.com/sites/preeminent-bienenstitch-606ad0/deploys/64c2a52b44e9c400089f931b
😎 Deploy Preview https://deploy-preview-1249--preeminent-bienenstitch-606ad0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ledwards2225 ledwards2225 self-requested a review July 27, 2023 17:15
ledwards2225
ledwards2225 approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@ledwards2225 ledwards2225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Full review took place on original bberg PR.

@Rumata888 Rumata888 changed the title goblin translator prototype feat: Goblin translator prototype Jul 27, 2023
@Rumata888 Rumata888 merged commit 838a2d6 into master Jul 27, 2023
@Rumata888 Rumata888 deleted the is/translatooooooooooooooooooor branch July 27, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ledwards2225 ledwards2225 ledwards2225 approved these changes

Assignees

@Rumata888 Rumata888

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rumata888 @ledwards2225