Try running an e2e test on circle instead of a spot instance #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalladino
force-pushed
the
palla/e2e-no-spot
branch
2 times, most recently
from
8181697 to
cef6b28
Compare
spalladino
force-pushed
the
palla/e2e-no-spot
branch
from
cef6b28 to
7780348
Compare
|
"but increase Circle costs (since we're going from small to large resource class machines)." and presumably also holding them for many more compute minutes |
|
Looks like this shaved off a bit on our tests. Looks good to me until we get a definite answer at least (although barretenberg repo mirror I guess will continue to have this issue) |
ludamad
approved these changes
Jul 27, 2023
True, but the number of spot instances requested by e2e tests was a lot more than the others. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces spot instance usage by running e2e tests directly in Circle machines (just like we build packages). This will decrease AWS costs since we'll be using a lot less spot instances (though they're really cheap) but increase Circle costs (since we're going from small to large resource class machines).