Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: L1 to L2 message size checks #1262

Merged
merged 6 commits into from
Jul 28, 2023
Merged

feat: L1 to L2 message size checks #1262

merged 6 commits into from
Jul 28, 2023

Conversation

benesjan
Copy link
Contributor

@benesjan benesjan commented Jul 28, 2023 •
edited
Loading

Description

Fixes #1263

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@benesjan benesjan marked this pull request as draft July 28, 2023 12:33
@benesjan benesjan requested a review from LHerskind July 28, 2023 12:56
@benesjan benesjan marked this pull request as ready for review July 28, 2023 12:56
@benesjan benesjan changed the title feat: L1 to L2 message content size check feat: L1 to L2 message content and secretHash size checks Jul 28, 2023
LHerskind
LHerskind reviewed Jul 28, 2023
View reviewed changes
Copy link
Contributor

@LHerskind LHerskind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be really annoying. As these two are only really to avoid user footguns on size of input, we should probably also perform the checks on the other user provided members such that they don't shoot themselves in any of those ways as well 🤷

@benesjan benesjan changed the title feat: L1 to L2 message content and secretHash size checks feat: L1 to L2 message size checks Jul 28, 2023
LHerskind
LHerskind approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@LHerskind LHerskind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good to me.

@benesjan benesjan merged commit c6f9a8d into master Jul 28, 2023
@benesjan benesjan deleted the janb/message-content-size-check branch July 28, 2023 14:51
LHerskind pushed a commit that referenced this pull request Jul 30, 2023
@benesjan @LHerskind
feat: L1 to L2 message size checks (#1262)
085d6f2 
# Description

Fixes #1263
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LHerskind LHerskind LHerskind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check message members can fit into a field in Inbox
2 participants
@benesjan @LHerskind